Skip to content

NO-ISSUE: Add intranet capability to SNO live-iso jobs#80413

Open
yoavsc0302 wants to merge 1 commit into
openshift:mainfrom
yoavsc0302:fix-sno-live-iso-ofcir
Open

NO-ISSUE: Add intranet capability to SNO live-iso jobs#80413
yoavsc0302 wants to merge 1 commit into
openshift:mainfrom
yoavsc0302:fix-sno-live-iso-ofcir

Conversation

@yoavsc0302

@yoavsc0302 yoavsc0302 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Add intranet capability to e2e-metal-sno-live-iso and
e2e-metal-sno-with-worker-live-iso so they get scheduled on
clusters that can reach OFCIR.

Without this, the dispatcher can assign these jobs to non-intranet
clusters (e.g. build02) where OFCIR is unreachable, causing
ofcir-acquire to hang and time out.

Example failure: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_assisted-test-infra/2814/pull-ci-openshift-assisted-test-infra-master-e2e-metal-sno-live-iso/2064962883023802368

Add intranet capability to e2e-metal-sno-live-iso and
e2e-metal-sno-with-worker-live-iso so they get scheduled on
clusters that can reach OFCIR.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@yoavsc0302: This pull request explicitly references no jira issue.

Details

In response to this:

Add intranet capability to e2e-metal-sno-live-iso and e2e-metal-sno-with-worker-live-iso so they get scheduled on clusters that can reach OFCIR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from rccrdpccl and tsorya June 11, 2026 12:23
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR adds capabilities: [intranet] configuration to two SNO test definitions in the OpenShift assisted test infrastructure configuration file. Both tests—e2e-metal-sno-live-iso and e2e-metal-sno-with-worker-live-iso—are marked to require intranet network access during CI execution.

Changes

Metal SNO Test Infrastructure

Layer / File(s) Summary
Add intranet capabilities to SNO live ISO tests
ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
Both e2e-metal-sno-live-iso and e2e-metal-sno-with-worker-live-iso test definitions now include capabilities: [intranet] to specify network requirements for CI job execution.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: adding the intranet capability to two SNO live-iso jobs for OFCIR scheduling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML CI/CD config file, not Ginkgo test code. Custom check applies to test titles in test code, not CI configuration.
Test Structure And Quality ✅ Passed PR modifies only a YAML CI configuration file, not Ginkgo test code. Custom check for test structure/quality is not applicable to this configuration-only change.
Microshift Test Compatibility ✅ Passed PR only adds YAML CI configuration (intranet capability); no new Ginkgo e2e tests are added, so check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR does not add new Ginkgo e2e tests; it only adds capabilities: [intranet] to two existing test job configurations. The custom check is inapplicable here.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only a CI test job configuration file, not deployment manifests, operator code, or controllers. The capabilities: [intranet] field is a cluster selection filter for Prow, not a t...
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI config (adds capabilities field), not test binary code. OTE Binary Stdout Contract check applies only to code changes that could emit non-JSON stdout in test binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR modifies a YAML CI configuration file, not Ginkgo e2e test code. The check applies only to new Ginkgo tests (It(), Describe(), etc.), which are not present in this PR.
No-Weak-Crypto ✅ Passed The PR modifies only a YAML CI/CD configuration file, adding capability tags to test definitions. No cryptographic code, weak crypto usage, or secret comparisons are present.
Container-Privileges ✅ Passed The PR modifies a CI/Prow test configuration file, not a container/K8s manifest. No privileged containers, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed PR adds intranet capability to test jobs in a YAML config file; no logging code, logging configurations, or any sensitive data (passwords, tokens, keys, PII) present or exposed.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yoavsc0302

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@yoavsc0302: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-test-infra-master-e2e-metal-sno-live-iso openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-sno-with-worker-live-iso openshift/assisted-test-infra presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yoavsc0302

Copy link
Copy Markdown
Contributor Author

/hold
/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@yoavsc0302: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@yoavsc0302: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/assisted-test-infra/master/e2e-metal-sno-live-iso 425c311 link unknown /pj-rehearse pull-ci-openshift-assisted-test-infra-master-e2e-metal-sno-live-iso
ci/rehearse/openshift/assisted-test-infra/master/e2e-metal-sno-with-worker-live-iso 425c311 link unknown /pj-rehearse pull-ci-openshift-assisted-test-infra-master-e2e-metal-sno-with-worker-live-iso

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants