Skip to content

pf-status-relay-operator: change install mode to AllNamespaces#80415

Open
karampok wants to merge 1 commit into
openshift:mainfrom
karampok:pf-status-allnamespaces
Open

pf-status-relay-operator: change install mode to AllNamespaces#80415
karampok wants to merge 1 commit into
openshift:mainfrom
karampok:pf-status-allnamespaces

Conversation

@karampok

@karampok karampok commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Change OO_INSTALL_MODE from OwnNamespace to AllNamespaces for pf-status-relay-operator e2e-validation test
  • Aligns with how other operators (e.g. sriov-network-operator) are installed in CI

Test plan

  • Rehearsal e2e-validation job passes with AllNamespaces mode

Summary by CodeRabbit

This PR updates the OpenShift CI configuration for the pf-status-relay-operator's e2e-validation test to use AllNamespaces installation mode instead of OwnNamespace.

What changed: The OO_INSTALL_MODE environment variable in the e2e-validation test step for the main branch configuration has been changed from OwnNamespace to AllNamespaces. This affects how the operator is installed during CI validation testing.

Impact: This aligns the pf-status-relay-operator's CI testing approach with other operators in the OpenShift ecosystem (such as sriov-network-operator). The AllNamespaces mode allows the operator to watch and manage resources across all namespaces during the e2e-validation test, rather than being restricted to a single namespace.

Scope: This change only affects the main branch configuration (openshift-pf-status-relay-operator-main.yaml). Other release branch configurations (5.1, 5.0, 4.x) remain unchanged with OwnNamespace mode.

Assisted-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3c9b9cdf-a203-401f-9c3b-c81c7ed8cfaf

📥 Commits

Reviewing files that changed from the base of the PR and between 82a7e5b and 59e8139.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main.yaml

Walkthrough

This PR updates the OpenShift CI configuration for the pf-status-relay-operator by changing the OO_INSTALL_MODE environment variable from OwnNamespace to AllNamespaces in the e2e-validation workflow, affecting how the operator is deployed during CI testing.

Changes

CI Configuration

Layer / File(s) Summary
Operator install mode configuration
ci-operator/config/openshift/pf-status-relay-operator/openshift-pf-status-relay-operator-main.yaml
OO_INSTALL_MODE is updated from OwnNamespace to AllNamespaces in the CI workflow environment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change in the pull request: updating the OO_INSTALL_MODE from OwnNamespace to AllNamespaces for the pf-status-relay-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files, not Ginkgo test code. No test names (dynamic or otherwise) are present in the changes.
Test Structure And Quality ✅ Passed PR contains only YAML CI configuration changes, no Ginkgo test code. Custom check for test quality is not applicable to this type of change.
Microshift Test Compatibility ✅ Passed PR only modifies CI configuration YAML (changing OO_INSTALL_MODE to AllNamespaces); no new Ginkgo e2e tests are added, so MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only changes CI configuration files (YAML) and does not add any new Ginkgo e2e tests. The check applies only to newly added tests, so it does not apply here.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI test configuration (OO_INSTALL_MODE environment variable), not deployment manifests, operator code, or Kubernetes scheduling constraints. Check scope does not apply.
Ote Binary Stdout Contract ✅ Passed PR changes only CI YAML configuration files; no source code or binary modifications exist for OTE Binary Stdout Contract evaluation.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR does not add new Ginkgo e2e tests; it only modifies YAML CI configuration (OO_INSTALL_MODE variable). Custom check is not applicable.
No-Weak-Crypto ✅ Passed Pull request only modifies CI configuration YAML file, changing an operator install mode setting; contains no cryptographic code, algorithms, or secret comparisons to check.
Container-Privileges ✅ Passed PR changes only OO_INSTALL_MODE environment variable in CI config; no privileged containers, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings present.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data (passwords, tokens, API keys, PII, session IDs, etc.) found in the file or logging statements. The change only updates an OO_INSTALL_MODE configuration parameter from OwnNamespace...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@karampok

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-ci openshift-ci Bot requested review from SchSeba and zeeke June 11, 2026 13:23
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karampok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@karampok: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-pf-status-relay-operator-main-e2e-validation openshift/pf-status-relay-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@karampok: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@karampok: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/pf-status-relay-operator/main/e2e-validation 59e8139 link unknown /pj-rehearse pull-ci-openshift-pf-status-relay-operator-main-e2e-validation

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant