Skip to content

Added csi-external-snapshotter tests for hypershift#80417

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
rvagner78:hypershift-snapshots
Jun 12, 2026
Merged

Added csi-external-snapshotter tests for hypershift#80417
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
rvagner78:hypershift-snapshots

Conversation

@rvagner78

@rvagner78 rvagner78 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR extends the OpenShift CI pipeline for the csi-external-snapshotter component to include HyperShift testing capabilities across multiple release branches.

What's changing:
The PR adds HyperShift test infrastructure to four CI configuration files:

  • openshift-csi-external-snapshotter-master.yaml (development branch)
  • openshift-csi-external-snapshotter-release-4.23.yaml
  • openshift-csi-external-snapshotter-release-5.0.yaml
  • openshift-csi-external-snapshotter-release-5.1.yaml

Changes in each file:
Each configuration file receives the same additions:

  1. A new base image reference pointing to hypershift-tests (sourced from the hypershift namespace with latest tag)
  2. A new end-to-end test entry called hypershift-aws-e2e-external that runs against the hypershift-aws cluster profile using the hypershift-aws-e2e-external workflow

Practical impact:
This enables automated testing of the CSI external snapshotter component in HyperShift environments (where OpenShift control planes run as workloads on hosting clusters), ensuring the snapshotter functionality works correctly across both standard OpenShift deployments and HyperShift configurations. The changes are consistent across all supported release branches, ensuring uniform testing coverage.

@openshift-ci openshift-ci Bot requested review from jmguzik and pruan-rht June 11, 2026 14:18
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5cf877cb-d8d8-4954-9c22-ac4500b342bd

📥 Commits

Reviewing files that changed from the base of the PR and between 51b034f and b548532.

📒 Files selected for processing (4)
  • ci-operator/config/openshift/csi-external-snapshotter/openshift-csi-external-snapshotter-master.yaml
  • ci-operator/config/openshift/csi-external-snapshotter/openshift-csi-external-snapshotter-release-4.23.yaml
  • ci-operator/config/openshift/csi-external-snapshotter/openshift-csi-external-snapshotter-release-5.0.yaml
  • ci-operator/config/openshift/csi-external-snapshotter/openshift-csi-external-snapshotter-release-5.1.yaml

Walkthrough

This PR adds HyperShift AWS E2E test support to the CSI external snapshotter OpenShift CI configurations. It introduces a hypershift-tests base image reference and a hypershift-aws-e2e-external test job consistently across the master branch and release branches 4.23, 5.0, and 5.1.

Changes

HyperShift Test Configuration Across All Branches

Layer / File(s) Summary
HyperShift tests base image and E2E test configuration
ci-operator/config/openshift/csi-external-snapshotter/openshift-csi-external-snapshotter-master.yaml, openshift-csi-external-snapshotter-release-5.1.yaml, openshift-csi-external-snapshotter-release-5.0.yaml, openshift-csi-external-snapshotter-release-4.23.yaml
Adds hypershift-tests base image entry (name: hypershift-tests, namespace: hypershift, tag: latest) and hypershift-aws-e2e-external test job (cluster_profile: hypershift-aws, workflow: hypershift-aws-e2e-external) to all CSI external snapshotter CI configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Suggested labels

rehearsals-ack

Suggested reviewers

  • hector-vido
  • enothen
  • bear-redhat
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Added csi-external-snapshotter tests for hypershift' accurately summarizes the main change: adding HyperShift-related test entries across multiple CI configuration files for the csi-external-snapshotter project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files; no Go test code or Ginkgo test definitions are present, so the check is not applicable.
Test Structure And Quality ✅ Passed PR contains only OpenShift CI configuration files (YAML), not Ginkgo test code. The custom check for test structure/quality is not applicable to CI configuration changes.
Microshift Test Compatibility ✅ Passed PR adds only CI configuration files (YAML) that reference existing test workflows, not new Ginkgo e2e tests. No test code files are modified.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only CI configuration entries (YAML files) with no new Ginkgo test code. The check applies to new test definitions (It(), Describe(), etc.), which are absent here.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI test configuration files (ci-operator/config and ci-operator/jobs), not deployment manifests, operator code, or controllers. The check applies only when the latter are added/mod...
Ote Binary Stdout Contract ✅ Passed PR contains only YAML CI configuration files and utility test output parsing tools, not OTE binaries. The stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains only CI configuration YAML changes (no Ginkgo test code). The check applies to "new Ginkgo e2e tests" but this PR only references existing workflows without adding test code.
No-Weak-Crypto ✅ Passed PR adds only YAML CI configuration files with test job and base image entries; no weak cryptographic algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or unsafe comparisons are...
Container-Privileges ✅ Passed No container privilege escalation flags, privileged modes, dangerous capabilities, or unsafe security settings found in the CI configuration files added by this PR.
No-Sensitive-Data-In-Logs ✅ Passed PR adds hypershift test configurations with no embedded passwords, tokens, API keys, PII, session IDs, hostnames, or customer data. Changes are configuration-only with standard resource references.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rvagner78

Copy link
Copy Markdown
Contributor Author

/test generated-config

rvagner78 and others added 2 commits June 12, 2026 08:41
@rvagner78 rvagner78 force-pushed the hypershift-snapshots branch from b548532 to 9365957 Compare June 12, 2026 06:49
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rvagner78: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-csi-external-snapshotter-master-hypershift-aws-e2e-external openshift/csi-external-snapshotter presubmit Presubmit changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-hypershift-aws-e2e-external openshift/csi-external-snapshotter presubmit Presubmit changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-hypershift-aws-e2e-external openshift/csi-external-snapshotter presubmit Presubmit changed
pull-ci-openshift-csi-external-snapshotter-release-5.1-hypershift-aws-e2e-external openshift/csi-external-snapshotter presubmit Presubmit changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-e2e-aws-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-e2e-gcp-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-e2e-vsphere openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-e2e-vsphere-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-images openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-unit openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-verify-commits openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-4.23-verify-deps openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-e2e-aws-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-e2e-gcp-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-e2e-vsphere openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-e2e-vsphere-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-images openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-unit openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-verify-commits openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-release-5.0-verify-deps openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-master-e2e-aws-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-master-e2e-gcp-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-master-e2e-vsphere openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-master-e2e-vsphere-csi openshift/csi-external-snapshotter presubmit Ci-operator config changed
pull-ci-openshift-csi-external-snapshotter-master-images openshift/csi-external-snapshotter presubmit Ci-operator config changed

A total of 38 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rvagner78

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-external-snapshotter-master-e2e-aws-csi

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rvagner78

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@rvagner78

Copy link
Copy Markdown
Contributor Author

/retest

@rvagner78

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-csi-external-snapshotter-release-4.23-hypershift-aws-e2e-external

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jsafrane

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/pj-rehearse ack
4.23 failure looks odd, however, other CI jobs (cluster-csi-snapshot-controller-operator) have the same setup and ther hypershift job passes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 12, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rvagner78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 57b22aa and 2 for PR HEAD 9365957 in total

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@rvagner78: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/csi-external-snapshotter/release-4.23/hypershift-aws-e2e-external 9365957 link unknown /pj-rehearse pull-ci-openshift-csi-external-snapshotter-release-4.23-hypershift-aws-e2e-external

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit db90237 into openshift:main Jun 12, 2026
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants