OCPBUGS-84114: Add hypershift-openstack-gather step#80419
Conversation
RHCOS_IMAGE_NAME fed --e2e.openstack-node-image-name, which was wired into DefaultOpenStackOptions() on 4.18 and earlier. Since e12e00159 (4.19+) ORC manages the image lifecycle directly for TestCreateCluster and TestNodePool, so the flag is no longer consumed by those tests. TestOpenStackAdvancedTest still honours it but is not in the default E2E_TESTS_REGEX. Clear the misleading "rhcos-latest-hcp-nodepool" default to "" and only pass the flag when the variable is non-empty. The 4.18 job configs that explicitly set RHCOS_IMAGE_NAME to a versioned image name are unaffected. Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
openshift-ci-robot
added
jira/severity-moderate
|
@stephenfin: This pull request references Jira Issue OCPBUGS-84114, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stephenfin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughPR adds a new OpenStack forensic gather step to HyperShift CI, makes RHCOS_IMAGE_NAME optional for E2E runs, and wires the gather step into the e2e-openstack-aws job's post-test workflow before destroy. ChangesOpenStack E2E Testing Enhancement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@stephenfin: This pull request references Jira Issue OCPBUGS-84114, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/hypershift/openstack/gather/hypershift-openstack-gather-commands.sh`:
- Around line 5-8: The file check using KUBECONFIG can fail under set -u when
the variable is unset; update the guard to use safe parameter expansion and
check for emptiness first, e.g. replace the if [[ ! -f "${KUBECONFIG}" ]] test
with a combined safe check using "${KUBECONFIG:-}" (for example: if [[ -z
"${KUBECONFIG:-}" || ! -f "${KUBECONFIG}" ]]; then ... ) so the script won’t
error on unbound KUBECONFIG and will still skip the gather path; adjust the
echo/exit behavior in the same block that references KUBECONFIG.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7cd6d984-fbcc-4896-bb08-d6d5aff37f69
📒 Files selected for processing (7)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/step-registry/hypershift/openstack/e2e/execute/hypershift-openstack-e2e-execute-commands.shci-operator/step-registry/hypershift/openstack/e2e/execute/hypershift-openstack-e2e-execute-ref.yamlci-operator/step-registry/hypershift/openstack/gather/OWNERSci-operator/step-registry/hypershift/openstack/gather/hypershift-openstack-gather-commands.shci-operator/step-registry/hypershift/openstack/gather/hypershift-openstack-gather-ref.metadata.jsonci-operator/step-registry/hypershift/openstack/gather/hypershift-openstack-gather-ref.yaml
This is vaguely based on the hypershift-analyze-e2e-failure step but much simpler (no AI integration). Signed-off-by: Stephen Finucane <stephenfin@redhat.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
stephenfin
force-pushed
the
fix-hypershift-gate
branch
from
859a7b1 to
d7ca9ea
Compare
|
[REHEARSALNOTIFIER]
A total of 42 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Add and enable a new
hypershift-openstack-gatherstep to the OpenStack HCP jobs. This allows us to gather information about cluster post-delete, which can help us prove some theories regardingWhile here, document the
RHCOS_IMAGE_NAMEoption and clear its default. This confused me. We might want to drop testing of 4.18 (and subsequently this option) since it's dev preview but that's left to another PR.Summary by CodeRabbit
This PR updates OpenShift CI configuration for the hypershift OpenStack Hosted Control Plane (HCP) workflows to add a short, best-effort diagnostic gather step and to clarify how an OpenStack RHCOS image name is passed to E2E tests.
Practical impact
Scope and affected CI config
Why this matters
Notes