NETOBSERV-2748: Disable NetObserv cron jobs#80424
Merged
openshift-merge-bot[bot] merged 1 commit intoJun 12, 2026
Merged
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@Amoghrd: This pull request references NETOBSERV-2748 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (16)
🚧 Files skipped from review as they are similar to previous changes (5)
WalkthroughThis PR disables periodic cron-triggered execution for NetObservability test jobs by removing/commenting ChangesNetObservability test schedule disablement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5 | ❌ 10❌ Failed checks (10 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__multi-nightly.yaml (1)
58-98:⚠️ Potential issue | 🔴 CriticalReplace commented-out
# cron:with “impossible date” parking—migrate script will re-enable them
migrate_periodic_file.pyrewrites any line containing the substringcron:into an activecron: '...'entry (it does not ignore# cron:), so the NetObserv jobs’ commented cron schedules inci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__multi-nightly.yamlwill be turned back on during periodic migrations. Use the documented “impossible date” cron parking pattern instead (e.g.,cron: '0 0 31 2 *'), since the migration script preserves day/month/day-of-week and only randomizes the time fields.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__multi-nightly.yaml` around lines 58 - 98, Replace the commented-out "# cron:" lines in the job blocks identified by "as: aws-ipi-amd-f60-netobserv" and "as: aws-ipi-arm-f60-netobserv" with an "impossible date" cron entry (e.g., cron: '0 0 31 2 *') so migrate_periodic_file.py does not re-enable them; update both job blocks' cron keys to use the documented impossible-date parking pattern while leaving other fields unchanged.Source: Learnings
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yaml (1)
74-93:⚠️ Potential issue | 🔴 CriticalRun
make updateto regenerateci-operator/jobsafter cron/schedule changes.
Cron/config changes inci-operator/configaren’t reflected in the generated Prow YAMLs underci-operator/jobs/openshift/openshift-tests-private/for this PR.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yaml` around lines 74 - 93, You changed the cron/config in ci-operator config for the job (openshift-openshift-tests-private-release-4.21__multi-nightly.yaml, job block referencing chain: openshift-e2e-test-netobserv-qe-pf5 and workflow cucushift-installer-rehearse-aws-ipi) but did not regenerate the derived Prow YAMLs; run the repository's generation step (make update) to regenerate ci-operator/jobs, verify the updated job YAMLs under ci-operator/jobs/openshift/openshift-tests-private/ reflect your changes (including reporter_config/cron or schedule differences), and commit the generated files alongside this config change.
🧹 Nitpick comments (2)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yaml (1)
74-93: ⚡ Quick winFollow the documented disablement pattern for consistency.
The NetObserv jobs are being disabled by commenting out the
cron:lines. While this functionally prevents periodic triggering, it does not follow the documented pattern for disabling periodic jobs in this repository.According to the documented approach, when disabling cron-scheduled jobs:
- Remove the
cron:line entirely (not just comment it out)- Add
always_run: falseas the first field before theas:lineThis pattern makes the intent explicit and is consistent with other job disablements in the repo.
♻️ Recommended pattern for disabling these jobs
For each NetObserv job, apply this pattern:
- as: aws-ipi-amd-f14-netobserv - # cron: 52 12 2,16 * * + always_run: false reporter_config:- as: aws-ipi-arm-f28-netobserv - # cron: 22 6 13 * * + always_run: false reporter_config:- as: azure-ipi-amd-f14-netobserv - # cron: 13 22 11,27 * * + always_run: false reporter_config:- as: gcp-ipi-amd-f14-netobserv - # cron: 36 8 9,25 * * + always_run: false reporter_config:Also applies to: 94-114, 974-993, 2008-2026
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yaml` around lines 74 - 93, Remove the commented-out cron lines and follow the repo's disablement pattern by inserting always_run: false as the first field before the as: line for the NetObserv jobs (i.e., add always_run: false above as: aws-ipi-amd-f14-netobserv and delete the commented "cron:" entry); apply the same change for the other NetObserv job blocks mentioned (the additional blocks referenced in the comment) so each disabled periodic job has always_run: false and no cron field.ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yaml (1)
74-93: 💤 Low valueConsider following the documented disabling pattern.
The cron line is commented out to disable this periodic job. According to the context snippet from
ci-operator/config/redhat-chaos/prow-scripts/agents/disable_version_jobs.md, the documented pattern for disabling cron-scheduled jobs is to remove thecron:line and addalways_run: falsebefore theas:field, for example:- always_run: false as: aws-ipi-amd-f14-netobserv # cron: 34 11 3,17 * *While commenting out the cron line achieves the immediate goal of disabling the job, following the documented pattern would improve consistency and make the disabled state more explicit.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yaml` around lines 74 - 93, The cron schedule for the periodic job (currently commented out) should follow the documented disabling pattern: remove or leave the commented cron line and explicitly add always_run: false immediately before the as: field for the job (as: aws-ipi-amd-f14-netobserv) so the disabled state is explicit and consistent with other jobs; update the block containing reporter_config/steps/test/workflow to include always_run: false above as and ensure no other references to cron remain that might re-enable the job.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml`:
- Line 4664: The five NetObserv jobs (vsphere-ipi-amd-f14-netobserv,
vsphere-ipi-amd-f28-techpreview-nwevents-netobserv,
metal-ds-ipi-ovn-ipv4-f28-virt-netobserv,
metal-ds-ipi-ovn-dualstack-primaryv6-f28-ipv6-netobserv,
vsphere-ipi-amd-f28-ipsec-netobserv) were only commented out for cron but remain
enabled as presubmits; edit their ci-operator config entries and either set
always_run: false for each job (remove any always_run: true) or remove the
presubmit generation entries entirely so they no longer appear in the generated
presubmits; search for the job names and update the always_run flag or remove
the presubmit blocks accordingly.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly.yaml`:
- Around line 74-75: The NetObserv periodic jobs (aws-ipi-amd-f7-netobserv,
aws-ipi-arm-f28-netobserv, azure-ipi-amd-f7-netobserv, gcp-ipi-amd-f7-netobserv)
were disabled by commenting out cron but are missing the required disable flag;
add always_run: false as the first YAML field for each of those job blocks
(i.e., insert always_run: false immediately before the existing as: <job-name>
entry) to complete the disable pattern.
---
Outside diff comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__multi-nightly.yaml`:
- Around line 58-98: Replace the commented-out "# cron:" lines in the job blocks
identified by "as: aws-ipi-amd-f60-netobserv" and "as:
aws-ipi-arm-f60-netobserv" with an "impossible date" cron entry (e.g., cron: '0
0 31 2 *') so migrate_periodic_file.py does not re-enable them; update both job
blocks' cron keys to use the documented impossible-date parking pattern while
leaving other fields unchanged.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yaml`:
- Around line 74-93: You changed the cron/config in ci-operator config for the
job (openshift-openshift-tests-private-release-4.21__multi-nightly.yaml, job
block referencing chain: openshift-e2e-test-netobserv-qe-pf5 and workflow
cucushift-installer-rehearse-aws-ipi) but did not regenerate the derived Prow
YAMLs; run the repository's generation step (make update) to regenerate
ci-operator/jobs, verify the updated job YAMLs under
ci-operator/jobs/openshift/openshift-tests-private/ reflect your changes
(including reporter_config/cron or schedule differences), and commit the
generated files alongside this config change.
---
Nitpick comments:
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yaml`:
- Around line 74-93: Remove the commented-out cron lines and follow the repo's
disablement pattern by inserting always_run: false as the first field before the
as: line for the NetObserv jobs (i.e., add always_run: false above as:
aws-ipi-amd-f14-netobserv and delete the commented "cron:" entry); apply the
same change for the other NetObserv job blocks mentioned (the additional blocks
referenced in the comment) so each disabled periodic job has always_run: false
and no cron field.
In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yaml`:
- Around line 74-93: The cron schedule for the periodic job (currently commented
out) should follow the documented disabling pattern: remove or leave the
commented cron line and explicitly add always_run: false immediately before the
as: field for the job (as: aws-ipi-amd-f14-netobserv) so the disabled state is
explicit and consistent with other jobs; update the block containing
reporter_config/steps/test/workflow to include always_run: false above as and
ensure no other references to cron remain that might re-enable the job.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 15e1e1e1-da64-47e9-a4ad-1ea5ad4e0e6d
⛔ Files ignored due to path filters (16)
ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (16)
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.16__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.18__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.19__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.21__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__amd64-nightly.yamlci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__multi-nightly.yaml
Amoghrd
force-pushed
the
disable-netobserv-cron
branch
from
1914af3 to
b211081
Compare
Contributor
|
[REHEARSALNOTIFIER]
A total of 62 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amoghrd, memodi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/pj-rehearse ack |
Contributor
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
Contributor
|
@Amoghrd: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling NetObserv jobs cron-trigger since we moved the tests upstream and CI still points to openshift-tests-private. So, disabling these jobs until we update the CI to point upstream
Summary by CodeRabbit
This PR disables scheduled NetObserv (NetObservability) cron-trigger jobs in the OpenShift CI configuration for the openshift-tests-private CI operator. It updates ci-operator job definitions across release branches (4.14 through 5.0, both amd64 and multi-nightly variants) so that NetObserv-related test jobs no longer have active cron schedules and instead include always_run: false. Practically, scheduled triggers for many NetObserv jobs (AWS/Azure/GCP/vSphere/bare-metal variants, dual-stack, IPsec, etc.) are removed/disabled; the job definitions themselves remain present and runnable, but they will not run on the prior periodic schedules.
Why: NetObserv tests were moved upstream while CI still pointed to openshift-tests-private. Disabling the cron triggers avoids running tests from the old location until CI is reconfigured to point at the upstream test repository. This is intended as a temporary workaround.
Scope & impact: Changes are confined to CI operator YAML configurations (ci-operator/config/openshift/openshift-tests-private/*). No application code or exported/public API changes. Behaviorally, automated periodic execution of the affected NetObserv jobs is paused; manual or job-triggered runs remain possible.
Notes from PR metadata: openshift-ci-robot validated the JIRA reference (NETOBSERV-2748) but warned the referenced issue lacks a target version while the PR target branch expects version 5.0.0.