stackrox: Add 3h timeout to ocp-4-create step#80452
Conversation
The ocp-4-create step had no explicit timeout, inheriting the 2h default from the Prow entrypoint. When the first provisioning attempt fails and the retry script starts a second attempt, 2h is not enough for two full OCP provisioning cycles. This caused nightly UI E2E tests to be killed mid-provisioning on the retry. 3h accommodates two full provisioning cycles comfortably. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe StackRox automation flavors OCP-4-E2E workflow is updated to increase the timeout for the ocp-4-create step to 3 hours, allowing longer-running cluster creation operations to complete without timing out. ChangesCI Workflow Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse |
|
@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-stackrox-stackrox-master-ocp-4-22-qa-e2e-tests |
|
@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 191 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
I do not object for this to be merged. We can do it and see how it goes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davdhacs, msugakov, tommartensen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
The ocp-4-create step had no explicit timeout, inheriting the 2h default from the Prow entrypoint. If the first provisioning attempt fails late in startup or otherwise takes >60min and the retry script starts a second attempt, 2h is not enough for two full OCP provisioning cycles. This caused nightly UI E2E tests to be killed mid-provisioning on the retry.
3h accommodates two full provisioning cycles.
/uncc
Summary by CodeRabbit
This PR updates the CI configuration for StackRox's OpenShift 4 end-to-end tests. Specifically, it adds an explicit 3-hour timeout to the
ocp-4-createstep in thestackrox-automation-flavors-ocp-4-e2eworkflow.Practical Impact:
Previously, this step inherited a 2-hour default timeout from Prow, which was insufficient when the initial cluster provisioning failed late in the startup sequence. In such cases, a retry script would attempt a second provisioning cycle, but the remaining time wouldn't accommodate a full second attempt, causing nightly UI E2E tests to be killed mid-provisioning.
The explicit 3-hour timeout ensures that two complete OpenShift 4 provisioning cycles can complete, allowing retry attempts to succeed even when the initial provisioning takes significant time.
File Changed:
ci-operator/step-registry/stackrox/automation-flavors/ocp-4-e2e/stackrox-automation-flavors-ocp-4-e2e-workflow.yaml— Addedtimeout: 3h0m0sto theocp-4-createpre-step