OCPBUGS-100190, CONSOLE-5234: Remove Cypress CI jobs, switch e2e-gcp-console to Playwright - #82685 - #82685
OCPBUGS-100190, CONSOLE-5234: Remove Cypress CI jobs, switch e2e-gcp-console to Playwright - #82685#82685shahsahil264 wants to merge 5 commits into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@shahsahil264: This pull request references CONSOLE-5234 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughConsole CI configurations now resolve Yarn from ChangesConsole CI updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold |
openshift-ci
Bot
added
do-not-merge/hold
|
put hold on this PR, as waiting for the complete migration of playwrights tests, once its done we can merge this! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/console/openshift-console-main.yaml`:
- Around line 37-38: Update the generated Yarn wrapper command in the Docker
build so the emitted script contains "$@" rather than "\$@". Remove the extra
escaping while preserving the existing node path and argument forwarding
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 91deb53f-f19a-453d-9c39-dfc5a16f0fde
📒 Files selected for processing (1)
ci-operator/config/openshift/console/openshift-console-main.yaml
logonoff
left a comment
logonoff
left a comment
There was a problem hiding this comment.
you probably want to make the same change in the other branches tracking main? like release-5.0, release-4.23, release-5.1, ...
|
/retitle OCPBUGS-100190, CONSOLE-5234: Remove Cypress CI jobs, switch e2e-gcp-console to Playwright - #82685 |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
the
jira/valid-bug
|
@shahsahil264: This pull request references Jira Issue OCPBUGS-100190, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. This pull request references CONSOLE-5234 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
shahsahil264
left a comment
shahsahil264
left a comment
There was a problem hiding this comment.
Done — applied the same changes to release-5.1, release-5.0, and release-4.23 configs + regenerated presubmits.
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@shahsahil264: This pull request references Jira Issue OCPBUGS-100190, which is valid. 3 validation(s) were run on this bug
This pull request references CONSOLE-5234 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse auto-ack |
|
@logonoff: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: logonoff, shahsahil264 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@shahsahil264: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…right - Update e2e-gcp-console to use console-playwright-runner image and run Playwright via test-prow-e2e.sh (which now runs Playwright) - Update e2e-gcp-console-techpreview similarly - Remove e2e-playwright and e2e-playwright-techpreview jobs (redundant now that e2e-gcp-console runs Playwright) - Remove Cypress credentials and dependencies - Reduce timeout from 6h to 2h (Playwright is faster)
Generated by `make jobs` — removes e2e-playwright and e2e-playwright-techpreview presubmit job definitions that are no longer needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sahil Shah <sahshah@redhat.com>
…sion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sahil Shah <sahshah@redhat.com>
The triple-escaped \"\\\$@\" produced "\$@" in the generated script, preventing argument forwarding. Use \"\$@\" to produce "$@". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sahil Shah <sahshah@redhat.com>
Apply the same e2e-gcp-console Playwright migration to release-4.23, release-5.0, and release-5.1 configs: switch image to console-playwright-runner, remove Cypress credentials, remove redundant e2e-playwright jobs, and use dynamic yarn path. Regenerated presubmits via make jobs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sahil Shah <sahshah@redhat.com>
8222d29 to
474c479
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
New changes are detected. LGTM label has been removed. |
|
@shahsahil264: |
3 participants
Summary
Switch the OpenShift Console E2E CI jobs from Cypress to Playwright as part of the Cypress-to-Playwright migration (CONSOLE-5234).
Changes to
ci-operator/config/openshift/console/openshift-console-main.yaml:e2e-gcp-console(required E2E job):from: src→from: console-playwright-runner(Playwright needs Chromium which is pre-installed in this image)test-prow-e2e.shnow runs Playwright (updated in openshift/console#16883)CYPRESS_RECORD_KEYcredential mount (no longer needed)CYPRESS_PLUGIN_PULL_SPEC→PLUGIN_PULL_SPECdependencye2e-gcp-console-techpreview:Removed jobs:
e2e-playwright— redundant now thate2e-gcp-consoleruns Playwrighte2e-playwright-techpreview— redundant now thate2e-gcp-console-techpreviewruns PlaywrightGenerated files
ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yaml— regenerated viamake jobsCompanion PR
test-prow-e2e.sh/cc @rhamilto @logonoff
Summary by CodeRabbit
console-playwright-runnerimage and removesCYPRESS_RECORD_KEYusage.e2e-gcp-console-techpreviewand updates its test script.PLUGIN_PULL_SPEC..yarnrc.ymland use it for installation and the generated Yarn wrapper.