ROSAENG-64505: strip junit output for rosa-hcp-external-auth-f3 - #83059
ROSAENG-64505: strip junit output for rosa-hcp-external-auth-f3#83059amandahla wants to merge 1 commit into
Conversation
Extend STRIP_JUNIT_OUTPUT from openshift#82252 to fullcycle runtime steps and enable it for rosa-hcp-external-auth-f3 so sidecar censoring does not replace day2 junit XML and break send-results-to-reportportal. Signed-off-by: Amanda Hager Lopes de Andrade Katz <amanda.katz@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
@amandahla: This pull request references ROSAENG-64505 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amandahla The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
WalkthroughROSA runtime steps now support optional removal of ChangesROSA JUnit output handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse rosa-hcp-external-auth-f3 |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/rosa/openshift-rosa-master__e2e.yaml (1)
154-154: 🗄️ Data Integrity & Integration | 🔵 TrivialRun the pending runtime rehearsal before merge.
Verify that
rosa-hcp-external-auth-f3uploads parseable JUnit XML and thatsend-results-to-reportportalordroute sendsucceeds.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/rosa/openshift-rosa-master__e2e.yaml` at line 154, Run the pending runtime rehearsal before merging: verify that rosa-hcp-external-auth-f3 produces parseable JUnit XML with STRIP_JUNIT_OUTPUT enabled, then confirm send-results-to-reportportal or droute send completes successfully.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ci-operator/config/openshift/rosa/openshift-rosa-master__e2e.yaml`:
- Line 154: Run the pending runtime rehearsal before merging: verify that
rosa-hcp-external-auth-f3 produces parseable JUnit XML with STRIP_JUNIT_OUTPUT
enabled, then confirm send-results-to-reportportal or droute send completes
successfully.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 1f1ee850-6c76-4f1b-9ac1-5aaf9691c482
📒 Files selected for processing (11)
ci-operator/config/openshift/rosa/openshift-rosa-master__e2e.yamlci-operator/step-registry/rosa/tests/runtime/day1-post/rosa-tests-runtime-day1-post-commands.shci-operator/step-registry/rosa/tests/runtime/day1-post/rosa-tests-runtime-day1-post-ref.yamlci-operator/step-registry/rosa/tests/runtime/day2/rosa-tests-runtime-day2-commands.shci-operator/step-registry/rosa/tests/runtime/day2/rosa-tests-runtime-day2-ref.yamlci-operator/step-registry/rosa/tests/runtime/destroy-post/rosa-tests-runtime-destroy-post-commands.shci-operator/step-registry/rosa/tests/runtime/destroy-post/rosa-tests-runtime-destroy-post-ref.yamlci-operator/step-registry/rosa/tests/runtime/destroy/rosa-tests-runtime-destroy-commands.shci-operator/step-registry/rosa/tests/runtime/destroy/rosa-tests-runtime-destroy-ref.yamlci-operator/step-registry/rosa/tests/runtime/destructive/rosa-tests-runtime-destructive-commands.shci-operator/step-registry/rosa/tests/runtime/destructive/rosa-tests-runtime-destructive-ref.yaml
|
@amandahla: job(s): rosa-hcp-external-auth-f3 either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse periodic-ci-openshift-rosa-master-e2e-rosa-hcp-external-auth-f3 |
|
/pj-rehearse --pull=openshift/rosa#3454 periodic-ci-openshift-rosa-master-e2e-rosa-hcp-upgrade-y-stream-f3 |
|
@amandahla: your |
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@amandahla: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amandahla: job(s): --pull=openshift/rosa#3454, periodic-ci-openshift-rosa-master-e2e-rosa-hcp-upgrade-y-stream-f3 either don't exist or were not found to be affected, and cannot be rehearsed |
|
@amandahla: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Enable
STRIP_JUNIT_OUTPUTforrosa-hcp-external-auth-f3so Prow sidecar censoring does not replace day2 JUnit XML and failsend-results-to-reportportal/droute send.Extends the same pattern introduced in #82252 (
8fbeb4865d1).Changes
STRIP_JUNIT_OUTPUTinto fullcycle runtime refs/scripts (day1-post,day2,destructive,destroy,destroy-post) using the same strip-before-cplogic asrosa-tests-commands.shSTRIP_JUNIT_OUTPUT: "true"onrosa-hcp-external-auth-f3Related
Test plan
make updatemake ci-operator-checkconfig/pj-rehearse rosa-hcp-external-auth-f3(or ack/skip after review)Made with Cursor
Summary by CodeRabbit
This PR updates ROSA HCP external-auth CI runs to prevent Prow sidecar censoring from corrupting day2 JUnit XML.
STRIP_JUNIT_OUTPUT=trueforrosa-hcp-external-auth-f3.system-outandsystem-errelements before copying JUnit results to artifacts.send-results-to-reportportalanddroute sendfailures.make updateandmake ci-operator-checkconfigcompleted. Rehearsal and periodic-run validation remain pending.