Add integration test presubmit for openshift/sippy

[redhat-chai-bot]

What

Adds a required integration test presubmit for openshift/sippy that runs make integration using nested-podman for testcontainers-go.

How

Uses the CI-provided nested-podman base image (ci/nested-podman:latest) following the documented nested-podman pattern. The nested-podman image already includes podman, catatonit, fuse-overlayfs, entrypoint script, and subuid/subgid setup.

A sippy-integration image is built on top of nested-podman using dockerfile_literal + inputs to copy the Go toolchain, gotestsum, node/npm, and sippy source from the src pipeline image.

Image build

base_images:
  nested-podman:
    namespace: ci
    name: nested-podman
    tag: latest

images:
  items:
  - from: nested-podman
    dockerfile_literal: |
      FROM nested-podman
      USER 0
      COPY golang /usr/lib/golang
      COPY node_modules /usr/lib/node_modules
      COPY bin/ /usr/bin/
      COPY --chown=1000:0 src /workspace
      RUN ln -sf /usr/lib/node_modules/npm/bin/npm-cli.js /usr/bin/npm && ln -sf /usr/lib/node_modules/npm/bin/npx-cli.js /usr/bin/npx
      ENV GOROOT=/usr/lib/golang
      ENV PATH=/usr/lib/golang/bin:${PATH}
      WORKDIR /workspace
      USER 1000
    inputs:
      src:
        paths:
        - destination_dir: golang
          source_path: /usr/lib/golang/.
        - destination_dir: node_modules
          source_path: /usr/lib/node_modules/.
        - destination_dir: bin
          source_path: /usr/bin/make
        - destination_dir: bin
          source_path: /usr/bin/gotestsum
        - destination_dir: bin
          source_path: /usr/bin/node
        - destination_dir: src
          source_path: /go/src/github.com/openshift/sippy/.
    to: sippy-integration

Integration test

- as: integration
  capabilities:
  - nested-podman
  commands: make integration
  container:
    from: sippy-integration
  nested_podman: true
  skip_if_only_changed: ^docs/|\.md$|^(?:.*/)?(?:\.gitignore|OWNERS|PROJECT|LICENSE)$

Generated presubmit

Job name: pull-ci-openshift-sippy-main-integration
Trigger: /test integration
Required for merge, skips doc-only changes.

[redhat-chai-bot]

/pj-rehearse auto-ack

---

AI-generated. Review for accuracy.

[openshift-merge-bot]

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/sippy/OWNERS
• ci-operator/jobs/openshift/sippy/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

Adds a sippy-integration image based on nested-podman and a CI test that runs make integration. Documentation-only changes skip the test.

Changes

Sippy integration CI

Layer / File(s)	Summary
Integration image setup ci-operator/config/openshift/sippy/openshift-sippy-main.yaml	Adds the nested-podman base image and defines sippy-integration with dependencies, build tools, Go settings, and repository sources at /workspace.
Integration test execution ci-operator/config/openshift/sippy/openshift-sippy-main.yaml	Adds a nested-Podman test that runs make integration and skips documentation-only changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CI
  participant SippyIntegration
  participant NestedPodman
  CI->>SippyIntegration: Run make integration
  SippyIntegration->>NestedPodman: Enable nested Podman
  NestedPodman-->>CI: Return integration result

Loading

Possibly related PRs

• openshift/release#83006: Extends the same Sippy integration image and nested-Podman presubmit setup.

Suggested reviewers: neisw, xueqzhan

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only CI YAML and a generated presubmit; no Ginkgo test titles or dynamic values appear in the added lines.
Test Structure And Quality	✅ Passed	The commit changes only CI YAML and generated Prow metadata; it adds no Ginkgo test code, so these test-structure requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The commit changes only two CI YAML files and adds no Ginkgo e2e tests or MicroShift-sensitive API references; the check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only CI YAML files and adds no Ginkgo e2e tests, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only ci-operator image and presubmit YAML; it adds no deployment, operator, controller, or topology-dependent scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only two YAML CI files; it adds a CI command but no OTE binary, suite hook, logging call, or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only CI YAML and adds no Ginkgo e2e test; therefore this IPv6/disconnected test check is not applicable.
No-Weak-Crypto	✅ Passed	The PR changes only CI YAML and generated Prow configuration; the added image and integration job contain no weak algorithms, custom crypto, or secret/token comparisons.
Container-Privileges	✅ Passed	The integration manifest has no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation setting; the image switches from build-time USER 0 to runtime USER 1000.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds CI/image configuration only; no added echo, print, or log statements expose secrets, PII, customer data, or credential values. Credentials use mounted file paths.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the addition of the integration test presubmit for openshift/sippy.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/sippy/openshift-sippy-main.yaml`:
- Around line 81-88: Run make update to regenerate and validate the generated
Prow job definitions and metadata for the new integration test configuration,
ensuring the resulting generated files are included in the change.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d0428582-fe50-4480-9630-0bc4549df394

📥 Commits

Reviewing files that changed from the base of the PR and between 1c5acc9 and 43d4181.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[redhat-chai-bot]

/pj-rehearse auto-ack

---

AI-generated. Review for accuracy.

[openshift-merge-bot]

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[redhat-chai-bot]

/pj-rehearse auto-ack

---

AI-generated. Review for accuracy.

[openshift-merge-bot]

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-sippy-main-integration	openshift/sippy	presubmit	Presubmit changed
pull-ci-openshift-sippy-main-agentic-images	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-agentic-staging	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-build	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-e2e	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-images	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-lint	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-security	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-unit	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-verify	openshift/sippy	presubmit	Ci-operator config changed
pull-ci-openshift-sippy-main-yaml-lint	openshift/sippy	presubmit	Ci-operator config changed
periodic-ci-openshift-sippy-main-agentic-periodic-sippy-jira-agent	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-sippy-main-agentic-periodic-sippy-pr-followup-agent	N/A	periodic	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/sippy/main/agentic-staging	c9df1ec	link	unknown	/pj-rehearse pull-ci-openshift-sippy-main-agentic-staging
ci/rehearse/periodic-ci-openshift-sippy-main-agentic-periodic-sippy-jira-agent	c9df1ec	link	unknown	/pj-rehearse periodic-ci-openshift-sippy-main-agentic-periodic-sippy-jira-agent
ci/rehearse/openshift/sippy/main/integration	c9df1ec	link	unknown	/pj-rehearse pull-ci-openshift-sippy-main-integration
ci/rehearse/periodic-ci-openshift-sippy-main-agentic-periodic-sippy-pr-followup-agent	c9df1ec	link	unknown	/pj-rehearse periodic-ci-openshift-sippy-main-agentic-periodic-sippy-pr-followup-agent

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.