Skip to content

CNTRLPLANE-4016: Add hypershift e2e-aws-mgmt-techpreview CI jobs with IPI management cluster - #83096

Open
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:capi_mgmt_compatibility
Open

CNTRLPLANE-4016: Add hypershift e2e-aws-mgmt-techpreview CI jobs with IPI management cluster#83096
mgencur wants to merge 1 commit into
openshift:mainfrom
mgencur:capi_mgmt_compatibility

Conversation

@mgencur

@mgencur mgencur commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

https://redhat.atlassian.net/browse/CNTRLPLANE-4016

Summary

Adds a new hypershift-aws-e2e-ipi-mgmt workflow and e2e-aws-mgmt-techpreview test jobs to validate HyperShift e2e tests running against an IPI-provisioned management cluster with FEATURE_SET=TechPreviewNoUpgrade for CAPI management compatibility.

Changes

  • New workflow: hypershift-aws-e2e-ipi-mgmt in the step registry — provisions a standalone OpenShift cluster via IPI on AWS (2-tier model) instead of the standard 3-tier nested management cluster, installs the HyperShift operator, and runs the nested e2e test suite
  • Optional presubmit on main branch (/test e2e-aws-mgmt-techpreview)
  • Optional presubmit on release-5.1 branch (/test e2e-aws-mgmt-techpreview)
  • Daily periodic on release-5.1 (cron: 0 3 * * *)

All jobs use cluster_profile: openshift-org-aws, FEATURE_SET: TechPreviewNoUpgrade on the management cluster, ENABLE_HYPERSHIFT_CERT_ROTATION_SCALE: "true", and nodepool version testing (N-1 through N-4).

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Summary by CodeRabbit

Adds optional and periodic e2e-aws-mgmt-techpreview CI jobs for HyperShift on main and release-5.1.

The jobs use the openshift-org-aws cluster profile and the hypershift-aws-e2e-ipi-mgmt workflow. The workflow provisions an AWS IPI management cluster, installs HyperShift, and runs nested TechPreviewNoUpgrade e2e tests.

The tests cover NodePool versions 4.22 through 4.19. The release-5.1 periodic job runs daily at 03:00 UTC. Certificate rotation scaling is enabled.

…luster

Add a new hypershift-aws-e2e-ipi-mgmt workflow that provisions a standalone
OpenShift management cluster via IPI on AWS (2-tier model) instead of the
standard 3-tier nested management cluster. This enables testing HyperShift
with FEATURE_SET=TechPreviewNoUpgrade on the management cluster for CAPI
compatibility validation.

Jobs added:
- Optional presubmit on main and release-5.1
- Daily periodic on release-5.1 (cron: 0 3 * * *)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@mgencur: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Adds a new hypershift-aws-e2e-ipi-mgmt workflow and e2e-aws-mgmt-techpreview test jobs to validate HyperShift e2e tests running against an IPI-provisioned management cluster with FEATURE_SET=TechPreviewNoUpgrade for CAPI management compatibility.

Changes

  • New workflow: hypershift-aws-e2e-ipi-mgmt in the step registry — provisions a standalone OpenShift cluster via IPI on AWS (2-tier model) instead of the standard 3-tier nested management cluster, installs the HyperShift operator, and runs the nested e2e test suite
  • Optional presubmit on main branch (/test e2e-aws-mgmt-techpreview)
  • Optional presubmit on release-5.1 branch (/test e2e-aws-mgmt-techpreview)
  • Daily periodic on release-5.1 (cron: 0 3 * * *)

All jobs use cluster_profile: openshift-org-aws, FEATURE_SET: TechPreviewNoUpgrade on the management cluster, ENABLE_HYPERSHIFT_CERT_ROTATION_SCALE: "true", and nodepool version testing (N-1 through N-4).

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgencur
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The change adds an AWS IPI management-cluster workflow for HyperShift and registers an optional TechPreview test across main, release, and daily periodic configurations.

Changes

HyperShift AWS management E2E

Layer / File(s) Summary
AWS IPI management workflow
ci-operator/step-registry/hypershift/aws/e2e/ipi-mgmt/*
The new workflow provisions an AWS IPI management cluster, installs HyperShift, resolves node-pool releases, runs nested e2e tests, and gathers diagnostics. Metadata and ownership entries register the workflow.
TechPreview test configuration
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1__periodics.yaml
The configurations add e2e-aws-mgmt-techpreview with the openshift-org-aws profile, TechPreviewNoUpgrade, NodePool versions 4.22 through 4.19, and the new workflow. The periodic job runs daily at 03:00.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PeriodicJob
  participant AWSIPIManagementCluster
  participant HyperShift
  participant NestedE2ETests
  PeriodicJob->>AWSIPIManagementCluster: Provision AWS IPI management cluster
  AWSIPIManagementCluster->>HyperShift: Install HyperShift and resolve releases
  HyperShift->>NestedE2ETests: Run nested e2e tests
  NestedE2ETests-->>AWSIPIManagementCluster: Gather diagnostics
Loading

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only CI YAML/JSON/OWNERS files; scans found no Ginkgo title declarations or dynamic test-title interpolation, and added job/workflow names are static.
Test Structure And Quality ✅ Passed The patch changes only CI YAML, JSON, and OWNERS files; no Ginkgo test code or It/BeforeEach/AfterEach/Eventually constructs were added or modified.
Microshift Test Compatibility ✅ Passed The PR adds only CI YAML/JSON/OWNERS files and invokes an existing nested e2e workflow; it adds no Ginkgo test declarations or new test code requiring MicroShift API review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR adds only CI YAML and workflow wiring; the diff contains no Go/test-source changes or new Ginkgo declarations, so the SNO test-compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR adds only CI workflows, job specs, and metadata; added lines contain no topology, affinity, node-selector, toleration, replica, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML/JSON and an OWNERS symlink; no Go or process-level code, stdout writes, logging, or OTE binary setup was added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR adds only CI YAML, metadata, and an OWNERS symlink; it adds no Ginkgo test source, IPv4 literals, URLs, or external-connectivity logic.
No-Weak-Crypto ✅ Passed The PR adds only CI YAML, metadata, and OWNERS; scans found no MD5, SHA-1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The added diff contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or runAs settings; the new workflow only references existing CI steps.
No-Sensitive-Data-In-Logs ✅ Passed The added workflow and job configs contain no secrets or sensitive values; they pass credential file paths only, and the referenced k8sgpt diagnostic uses anonymized output.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the new HyperShift AWS TechPreview CI jobs and IPI management cluster workflow.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from cblecker and csrwng August 7, 2026 11:45
@mgencur

mgencur commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/hold
Needs proper JIRA that will be under https://redhat.atlassian.net/browse/OCPSTRAT-3538

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mgencur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-aws-mgmt-techpreview openshift/hypershift presubmit Presubmit changed
pull-ci-openshift-hypershift-release-5.1-e2e-aws-mgmt-techpreview openshift/hypershift presubmit Presubmit changed
periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-mgmt-techpreview N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgencur

mgencur commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-mgmt-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`:
- Around line 353-354: The three management-job environment blocks require the
installer input TECH_PREVIEW_NO_UPGRADE set to "true"; FEATURE_SET alone is
insufficient. Add TECH_PREVIEW_NO_UPGRADE: "true" in
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml:353-354,
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1.yaml:340-341,
and
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1__periodics.yaml:242-243,
then run make update.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 04625010-3f95-45d7-a8fb-41713719a3a4

📥 Commits

Reviewing files that changed from the base of the PR and between 514dd15 and e9e514d.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.1-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.1-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (6)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1__periodics.yaml
  • ci-operator/step-registry/hypershift/aws/e2e/ipi-mgmt/OWNERS
  • ci-operator/step-registry/hypershift/aws/e2e/ipi-mgmt/hypershift-aws-e2e-ipi-mgmt-workflow.metadata.json
  • ci-operator/step-registry/hypershift/aws/e2e/ipi-mgmt/hypershift-aws-e2e-ipi-mgmt-workflow.yaml

@mgencur

mgencur commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-mgmt-techpreview

The release-5.1-periodics-e2e-aws-mgmt-techpreview failed because there's no suitable CI stream for 5.1 yet.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mgencur mgencur changed the title NO-JIRA: Add hypershift e2e-aws-mgmt-techpreview CI jobs with IPI management cluster CNTRLPLANE-4016: Add hypershift e2e-aws-mgmt-techpreview CI jobs with IPI management cluster Aug 7, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@mgencur: This pull request references CNTRLPLANE-4016 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds a new hypershift-aws-e2e-ipi-mgmt workflow and e2e-aws-mgmt-techpreview test jobs to validate HyperShift e2e tests running against an IPI-provisioned management cluster with FEATURE_SET=TechPreviewNoUpgrade for CAPI management compatibility.

Changes

  • New workflow: hypershift-aws-e2e-ipi-mgmt in the step registry — provisions a standalone OpenShift cluster via IPI on AWS (2-tier model) instead of the standard 3-tier nested management cluster, installs the HyperShift operator, and runs the nested e2e test suite
  • Optional presubmit on main branch (/test e2e-aws-mgmt-techpreview)
  • Optional presubmit on release-5.1 branch (/test e2e-aws-mgmt-techpreview)
  • Daily periodic on release-5.1 (cron: 0 3 * * *)

All jobs use cluster_profile: openshift-org-aws, FEATURE_SET: TechPreviewNoUpgrade on the management cluster, ENABLE_HYPERSHIFT_CERT_ROTATION_SCALE: "true", and nodepool version testing (N-1 through N-4).

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Summary by CodeRabbit

Adds optional and periodic e2e-aws-mgmt-techpreview CI jobs for HyperShift on main and release-5.1.

The jobs use the openshift-org-aws cluster profile and the hypershift-aws-e2e-ipi-mgmt workflow. The workflow provisions an AWS IPI management cluster, installs HyperShift, and runs nested TechPreviewNoUpgrade e2e tests.

The tests cover NodePool versions 4.22 through 4.19. The release-5.1 periodic job runs daily at 03:00 UTC. Certificate rotation scaling is enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@mgencur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-mgmt-techpreview e9e514d link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-mgmt-techpreview
ci/rehearse/openshift/hypershift/main/e2e-aws-mgmt-techpreview e9e514d link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aws-mgmt-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cblecker

Copy link
Copy Markdown
Member

/uncc

@openshift-ci
openshift-ci Bot removed the request for review from cblecker August 10, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants