Declare MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA as medik8s-catalogsource parameter - #83097
Conversation
|
Warning Review limit reached
Next review available in: 41 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe medik8s steps now expose Changesmedik8s FBC commit override
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
7f51781 to
9371f14
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
When Gangway triggers a job with pod_spec_options.envs containing MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA, ci-operator's applyEnvOverrides stores it in TestEnvironment with the full prefixed key name. However, generateParams only injects env vars into step pods when they match a declared step parameter name. Since only FBC_COMMIT_SHA was declared, the override was silently dropped and the step always resolved the latest FBC image from Quay instead of using the pinned SHA. Declaring MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA as a step parameter makes generateParams find the entry and inject it into the step pod. Applied to both catalogsource steps: - medik8s-catalogsource (connected): already had the bash fallback - medik8s-disconnected-catalogsource: added bash fallback + parameter Co-Authored-By: Claude <noreply@anthropic.com>
9371f14 to
bf8558c
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@ugreener: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse skip |
|
@ugreener: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slintes, ugreener, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…penshift#83097) When Gangway triggers a job with pod_spec_options.envs containing MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA, ci-operator's applyEnvOverrides stores it in TestEnvironment with the full prefixed key name. However, generateParams only injects env vars into step pods when they match a declared step parameter name. Since only FBC_COMMIT_SHA was declared, the override was silently dropped and the step always resolved the latest FBC image from Quay instead of using the pinned SHA. Declaring MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA as a step parameter makes generateParams find the entry and inject it into the step pod. Applied to both catalogsource steps: - medik8s-catalogsource (connected): already had the bash fallback - medik8s-disconnected-catalogsource: added bash fallback + parameter Co-authored-by: Claude <noreply@anthropic.com>
…penshift#83097) When Gangway triggers a job with pod_spec_options.envs containing MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA, ci-operator's applyEnvOverrides stores it in TestEnvironment with the full prefixed key name. However, generateParams only injects env vars into step pods when they match a declared step parameter name. Since only FBC_COMMIT_SHA was declared, the override was silently dropped and the step always resolved the latest FBC image from Quay instead of using the pinned SHA. Declaring MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA as a step parameter makes generateParams find the entry and inject it into the step pod. Applied to both catalogsource steps: - medik8s-catalogsource (connected): already had the bash fallback - medik8s-disconnected-catalogsource: added bash fallback + parameter Co-authored-by: Claude <noreply@anthropic.com>
…penshift#83097) When Gangway triggers a job with pod_spec_options.envs containing MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA, ci-operator's applyEnvOverrides stores it in TestEnvironment with the full prefixed key name. However, generateParams only injects env vars into step pods when they match a declared step parameter name. Since only FBC_COMMIT_SHA was declared, the override was silently dropped and the step always resolved the latest FBC image from Quay instead of using the pinned SHA. Declaring MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA as a step parameter makes generateParams find the entry and inject it into the step pod. Applied to both catalogsource steps: - medik8s-catalogsource (connected): already had the bash fallback - medik8s-disconnected-catalogsource: added bash fallback + parameter Co-authored-by: Claude <noreply@anthropic.com>
3 participants
Problem
When the medik8s CI dashboard triggers Prow jobs via Gangway with
pod_spec_options.envscontainingMULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHAto pin a specific FBC snapshot, the override is silently dropped. ci-operator'sapplyEnvOverridesstores env vars inTestEnvironmentwith the full prefixed key name, butgenerateParamsonly injects env vars into step pods when they match a declared step parameter name. Since onlyFBC_COMMIT_SHAwas declared, the prefixed lookup missed.This affects all dashboard-triggered jobs: connected (weekly), disconnected, and upgrade.
Summary
Declare
MULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHAas a step parameter in both catalogsource step refs sogenerateParamsfinds the entry and injects it into the step pod.Changes
medik8s-catalogsource-ref.yaml: addMULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHAparameter (step script already reads it)medik8s-disconnected-catalogsource-ref.yaml: addMULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHAparametermedik8s-disconnected-catalogsource-commands.sh: add bash fallback to readMULTISTAGE_PARAM_OVERRIDE_FBC_COMMIT_SHA(matching the connected step's pattern)Summary by CodeRabbit
This change updates the Medik8s catalog source CI steps. It passes an optional FBC commit SHA from Gangway through
ci-operatorto the step pod.When the override is set, the disconnected catalog source step uses it before the existing FBC commit value. The parameter defaults to an empty value, so existing behavior remains unchanged when Gangway does not provide an override.