Skip to content

api: make verify-hypershift-integration optional - #83107

Open
patrickdillon wants to merge 1 commit into
openshift:mainfrom
patrickdillon:api-optional-hypershift-verify
Open

api: make verify-hypershift-integration optional#83107
patrickdillon wants to merge 1 commit into
openshift:mainfrom
patrickdillon:api-optional-hypershift-verify

Conversation

@patrickdillon

@patrickdillon patrickdillon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The job is permafailing so we should make it optional in order to not block merges.

https://redhat.atlassian.net/browse/OCPBUGS-99050

Summary by CodeRabbit

The verify-hypershift-integration CI job is now optional. Persistent failures in this job will not block merges for the OpenShift API component repository.

References OCPBUGS-99050.

The job is permafailing so we should make it optional in order to
not block merges.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b0529e62-973c-42b9-bd55-83d8a571829f

📥 Commits

Reviewing files that changed from the base of the PR and between 9e47b6e and 866e426.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/api/openshift-api-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/api/openshift-api-master.yaml

Walkthrough

The OpenShift API master configuration marks the API test job as optional.

Changes

API test configuration

Layer / File(s) Summary
Make API test job optional
ci-operator/config/openshift/api/openshift-api-master.yaml
The API test job now uses optional: true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: joelspeed

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: making the verify-hypershift-integration job optional.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds optional: true to CI YAML; it changes no Ginkgo test titles or test code.
Test Structure And Quality ✅ Passed The commit changes only two YAML CI configuration files; it adds no Ginkgo test code, so the listed test-structure checks are not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only CI YAML files and adds no Ginkgo tests or test code, so MicroShift compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only two CI YAML files by adding optional: true; it adds no Go or Ginkgo tests, so SNO compatibility rules do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only marks a CI test and its generated Prow presubmit as optional; it adds no deployment, controller, operator, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The commit changes only two CI YAML files to add optional: true; it adds no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR only marks the existing verify-hypershift-integration job optional in two YAML files; it adds no Ginkgo tests or new IPv4 or external-connectivity assumptions.
No-Weak-Crypto ✅ Passed The patch adds only optional: true to the test and generated presubmit job; added lines contain no weak algorithms, crypto implementation, or secret comparison.
Container-Privileges ✅ Passed The PR adds only optional: true to verify-hypershift-integration; the changed manifest has no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds optional: true to verify-hypershift-integration; it adds no logging and exposes no sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@patrickdillon: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-api-master-verify-hypershift-integration openshift/api presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant