Add 15 informing jobs to 4.23 nightly release controller - #83109
Add 15 informing jobs to 4.23 nightly release controller#83109redhat-chai-bot wants to merge 1 commit into
Conversation
openshift-merge-bot
Bot
added
the
rehearsals-ack
WalkthroughThe release-controller configurations add optional OCP 4.23 verification jobs for AWS, Azure, GCP, metal, and vSphere. The changes include platform-specific upgrade, minor-upgrade, networking, single-node, and control-plane machine-set operator jobs. ChangesOCP 4.23 verification jobs
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/release-controller/_releases/priv/release-ocp-4.23.json`:
- Around line 213-220: Restore the missing comma after the preceding property
and before the metal-ipi-ovn-upgrade configuration entry so the JSON remains
valid and the release controller can parse it.
In `@core-services/release-controller/_releases/release-ocp-4.23.json`:
- Around line 142-263: Resolve the upgrade-analysis-all release gate by ensuring
its prowJob name references a checked-in Prow definition under ci-operator/jobs;
add the matching ProwJob configuration if that job is intended to remain
enabled, otherwise remove the entire upgrade-analysis-all entry.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 2a6bf9b7-7d9c-42c4-89a7-9d05d8920e05
📒 Files selected for processing (2)
core-services/release-controller/_releases/priv/release-ocp-4.23.jsoncore-services/release-controller/_releases/release-ocp-4.23.json
| "metal-ipi-ovn-upgrade": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ipi-ovn-upgrade" | ||
| }, | ||
| "upgrade": true | ||
| }, | ||
| "metal-ipi-ovn-upgrade-minor": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-upgrade-from-stable-4.22-e2e-metal-ipi-ovn-upgrade" | ||
| }, | ||
| "upgrade": true, | ||
| "upgradeFromRelease": { | ||
| "candidate": { | ||
| "stream": "nightly", | ||
| "version": "4.22" | ||
| } | ||
| } | ||
| }, | ||
| "metal-ipi-upgrade-ovn-ipv6": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ipi-upgrade-ovn-ipv6" | ||
| }, | ||
| "upgrade": true | ||
| }, | ||
| "metal-ipi-upgrade-ovn-ipv6-minor": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-upgrade-from-stable-4.22-e2e-metal-ipi-upgrade-ovn-ipv6" | ||
| }, | ||
| "upgrade": true, | ||
| "upgradeFromRelease": { | ||
| "candidate": { | ||
| "stream": "nightly", | ||
| "version": "4.22" | ||
| } | ||
| } | ||
| }, | ||
| "metal-ipi-ovn-dualstack": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-e2e-metal-ipi-ovn-dualstack" | ||
| } | ||
| }, | ||
| "vsphere-ovn-upgrade-micro": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-ci-4.23-e2e-vsphere-ovn-upgrade" | ||
| }, | ||
| "upgrade": true | ||
| }, | ||
| "vsphere-ovn-upgrade-minor": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-ci-4.23-upgrade-from-stable-4.22-e2e-vsphere-ovn-upgrade" | ||
| }, | ||
| "upgrade": true, | ||
| "upgradeFromRelease": { | ||
| "candidate": { | ||
| "stream": "nightly", | ||
| "version": "4.22" | ||
| } | ||
| } | ||
| }, | ||
| "aws-ovn-single-node-upgrade-minor": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-upgrade-from-stable-4.22-e2e-aws-upgrade-ovn-single-node" | ||
| }, | ||
| "upgrade": true, | ||
| "upgradeFromRelease": { | ||
| "candidate": { | ||
| "stream": "nightly", | ||
| "version": "4.22" | ||
| } | ||
| } | ||
| }, | ||
| "aws-ovn-single-node-techpreview": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-ovn-single-node-techpreview" | ||
| } | ||
| }, | ||
| "aws-ovn-single-node-techpreview-serial": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-e2e-aws-ovn-single-node-techpreview-serial" | ||
| } | ||
| }, | ||
| "aws-control-plane-machine-set-operator": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.23-periodics-e2e-aws" | ||
| } | ||
| }, | ||
| "azure-control-plane-machine-set-operator": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.23-periodics-e2e-azure" | ||
| } | ||
| }, | ||
| "gcp-control-plane-machine-set-operator": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.23-periodics-e2e-gcp" | ||
| } | ||
| }, | ||
| "gcp-ovn-serial": { | ||
| "optional": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-e2e-gcp-ovn-serial" | ||
| } | ||
| }, | ||
| "upgrade-analysis-all": { | ||
| "optional": true, | ||
| "maxRetries": 2, | ||
| "multiJobAnalysis": true, | ||
| "prowJob": { | ||
| "name": "periodic-ci-openshift-release-main-nightly-4.23-upgrade-analysis-all" | ||
| } |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
config='core-services/release-controller/_releases/release-ocp-4.23.json'
jq -e . "$config" >/dev/null
keys=(
metal-ipi-ovn-upgrade
metal-ipi-ovn-upgrade-minor
metal-ipi-upgrade-ovn-ipv6
metal-ipi-upgrade-ovn-ipv6-minor
metal-ipi-ovn-dualstack
vsphere-ovn-upgrade-micro
vsphere-ovn-upgrade-minor
aws-ovn-single-node-upgrade-minor
aws-ovn-single-node-techpreview
aws-ovn-single-node-techpreview-serial
aws-control-plane-machine-set-operator
azure-control-plane-machine-set-operator
gcp-control-plane-machine-set-operator
gcp-ovn-serial
upgrade-analysis-all
)
missing=0
for key in "${keys[@]}"; do
job="$(jq -er --arg key "$key" '.verify[$key].prowJob.name' "$config")"
if ! rg -n -F --glob '*.yaml' --glob '*.yml' "name: $job" ci-operator/jobs; then
printf 'Missing ProwJob definition: %s (%s)\n' "$key" "$job" >&2
missing=1
fi
done
exit "$missing"Repository: openshift/release
Length of output: 5980
Resolve the upgrade-analysis-all ProwJob reference.
periodic-ci-openshift-release-main-nightly-4.23-upgrade-analysis-all is not present under ci-operator/jobs, so this enabled release gate can be launched without a checked-in Prow definition. Add the matching ProwJob config or remove the gate.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@core-services/release-controller/_releases/release-ocp-4.23.json` around
lines 142 - 263, Resolve the upgrade-analysis-all release gate by ensuring its
prowJob name references a checked-in Prow definition under ci-operator/jobs; add
the matching ProwJob configuration if that job is intended to remain enabled,
otherwise remove the entire upgrade-analysis-all entry.
Source: Learnings
Adds metal upgrades (IPv4+IPv6 micro/minor + dualstack), vSphere upgrades (micro/minor), AWS SNO (minor upgrade + techpreview), CPMSO (AWS/Azure/GCP), and gcp-ovn-serial. All new entries match 4.22 equivalents with no maxRetries.
148189a to
fbec55d
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/release-controller/_releases/release-ocp-4.23.json`:
- Around line 221-255: Reconcile the release objective with the configured
verification jobs: either add the missing upgrade-analysis-all release entry and
its corresponding 4.23 ProwJob, or revise the objective to accurately describe
the 14 jobs currently added. Keep the release gate and objective consistent.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: d1f44718-d799-45da-9c78-f06321c14eec
📒 Files selected for processing (2)
core-services/release-controller/_releases/priv/release-ocp-4.23.jsoncore-services/release-controller/_releases/release-ocp-4.23.json
🚧 Files skipped from review as they are similar to previous changes (1)
- core-services/release-controller/_releases/priv/release-ocp-4.23.json
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Adds 15 informing jobs to the 4.23.0-0.nightly release controller config.
Changes
Appends 15 new
verifyentries torelease-ocp-4.23.json(15 existing → 30 total).Existing entries are untouched — the diff is pure additions with zero deletions.
New jobs
Metal upgrades + dualstack (5):
metal-ipi-ovn-upgrade— micro upgrademetal-ipi-ovn-upgrade-minor— minor upgrade from 4.22metal-ipi-upgrade-ovn-ipv6— IPv6 micro upgrademetal-ipi-upgrade-ovn-ipv6-minor— IPv6 minor upgrade from 4.22metal-ipi-ovn-dualstack— dualstack e2evSphere upgrades (2):
vsphere-ovn-upgrade-micro— micro upgradevsphere-ovn-upgrade-minor— minor upgrade from 4.22AWS SNO (3):
aws-ovn-single-node-upgrade-minor— minor upgrade from 4.22aws-ovn-single-node-techpreview— TechPreview e2eaws-ovn-single-node-techpreview-serial— TechPreview serialCPMSO (3):
aws-control-plane-machine-set-operatorazure-control-plane-machine-set-operatorgcp-control-plane-machine-set-operatorGCP (1):
gcp-ovn-serialAnalysis (1):
upgrade-analysis-all— aggregate upgrade analysis (multiJobAnalysis: true, maxRetries: 2)Configuration
All entries are
optional: truewith nomaxRetries, matching 4.22 equivalents — exceptupgrade-analysis-allwhich usesmaxRetries: 2andmultiJobAnalysis: trueper the 4.22 pattern.All periodic Prow jobs already exist.
make release-controllershas been run to generate the companionpriv/release-ocp-4.23.json.AI-generated. Review for accuracy.
@neisw requested via Chai Bot
Summary by CodeRabbit
upgrade-analysis-allwithmaxRetries: 2andmultiJobAnalysis: true.make release-controllers.