debug-cluster-e2e-aks: add wait step and image override for TLS testing - #83174
debug-cluster-e2e-aks: add wait step and image override for TLS testing#83174kaleemsiddiqu wants to merge 2 commits into
Conversation
Add wait ref and OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to e2e-aks test for debugging PR openshift/hypershift#8864 (centralized TLS config for cloud-controller-manager). Replace TODO-FILL-IN with the CI registry namespace from the PR's images job before pushing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
WalkthroughThe ChangesAzure AKS E2E execution
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaleemsiddiqu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`:
- Line 181: Update OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to use the actual CI
registry namespace assigned to this pipeline’s images job instead of the
placeholder ci-op-abc123xyz, while preserving the existing registry path,
pipeline tag, and hypershift-operator image reference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2649072d-5005-4158-8e7a-a07537013a88
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
|
@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
|
@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Image from release-openshift-origin-installer-launch-aws-modern job 2086756237780717568 on build10. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
48b17d2 to
efc294e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`:
- Around line 184-186: Run make update to regenerate the affected CI
configuration, then review the generated diffs. Use the generated Prow job
configuration, preserving its --target=e2e-aks reference and avoiding manually
inlining test steps or running separate update commands.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e1221724-e40e-4312-9b90-569a71547252
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
| test: | ||
| - ref: wait | ||
| - ref: hypershift-azure-run-e2e |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -u
file='ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml'
printf '%s\n' '--- working tree ---'
git status --short
printf '%s\n' '--- relevant YAML ---'
sed -n '165,200p' "$file"
printf '%s\n' '--- diff summary ---'
git diff --stat -- "$file" Makefile ci-operator
printf '%s\n' '--- diff for relevant YAML ---'
git diff -- "$file"
printf '%s\n' '--- repository instructions and generation targets ---'
find .. -name AGENTS.md -o -name CONTRIBUTING.md -o -name Makefile | sort | head -80
rg -n --no-heading '(^|[[:space:]])(update|registry-metadata|ci-operator-config|jobs):|make update|zz_generated_metadata|prow' \
Makefile ci-operator 2>/dev/null | head -200
printf '%s\n' '--- likely generated files ---'
git ls-files | rg '(^|/)(zz_generated_metadata|prow|jobs|ci-operator-config|registry-metadata)' | head -200Repository: openshift/release
Length of output: 45095
🏁 Script executed:
#!/bin/bash
set -u
printf '%s\n' '--- Makefile target definitions ---'
sed -n '65,125p' Makefile
printf '%s\n' '--- hypershift generated jobs ---'
find ci-operator/jobs -maxdepth 4 -type f -iname '*hypershift*' -print | sort
printf '%s\n' '--- references to the affected config and steps ---'
rg -n --no-heading 'openshift-hypershift-main|hypershift-azure-run-e2e|as: e2e-aks' \
ci-operator/jobs ci-operator/config/openshift/hypershift 2>/dev/null | head -120
printf '%s\n' '--- metadata in the affected config ---'
rg -n --no-heading -A12 -B2 'zz_generated_metadata:' \
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlRepository: openshift/release
Length of output: 32887
🏁 Script executed:
#!/bin/bash
set -u
job='ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml'
config='ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml'
printf '%s\n' '--- generated e2e-aks job ---'
sed -n '270,372p' "$job"
printf '%s\n' '--- generated job references to affected steps ---'
rg -n --no-heading -C3 'hypershift-azure-run-e2e|ref: wait|e2e-aks' "$job" | head -120
printf '%s\n' '--- config metadata and all generated metadata references ---'
rg -n --no-heading -C2 'zz_generated_metadata:|branch: main|org: openshift|repo: hypershift' "$config" | head -40
printf '%s\n' '--- read-only structural check ---'
python3 - <<'PY'
from pathlib import Path
config = Path("ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml").read_text()
job = Path("ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml").read_text()
print("config_has_wait:", "- ref: wait" in config)
print("config_has_hypershift_azure_run_e2e:", "- ref: hypershift-azure-run-e2e" in config)
print("job_has_hypershift_azure_run_e2e:", "hypershift-azure-run-e2e" in job)
print("job_has_ref_wait:", "ref: wait" in job)
print("job_has_e2e_aks_job:", "pull-ci-openshift-hypershift-main-e2e-aks" in job)
PYRepository: openshift/release
Length of output: 7030
Run make update and review the generated diffs.
make update already runs jobs, ci-operator-config, and registry-metadata; no separate command sequence is required. The generated Prow job references --target=e2e-aks and does not inline the test steps.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`
around lines 184 - 186, Run make update to regenerate the affected CI
configuration, then review the generated diffs. Use the generated Prow job
configuration, preserving its --target=e2e-aks reference and avoiding manually
inlining test steps or running separate update commands.
Sources: Coding guidelines, Learnings
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
|
@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@kaleemsiddiqu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Add wait ref and OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to e2e-aks test for debugging PR openshift/hypershift#8864 (centralized TLS config for cloud-controller-manager). Replace TODO-FILL-IN with the CI registry namespace from the PR's images job before pushing.
Summary by CodeRabbit
openshift/hypershiftAzure AKS E2E CI test.hypershift-azure-run-e2etest step.OVERRIDE_HYPERSHIFT_OPERATOR_IMAGEfor centralized TLS debugging.TODO-FILL-INplaceholder until the CI registry namespace is available.