NO-JIRA: require verified label for kedacore-http-add-on - #83231
Conversation
Mirrors the pattern used by kedacore-keda and other autoscaler projects. Changes: - Split single Tide query into branch-specific queries - Release branches (4.22-5.1): require verified, backport-risk-assessed, jira/valid-bug - main: require verified only, add keep-main-query-separate guard Signed-off-by: Vincent Link <vlink@redhat.com>
|
@linkvt: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold until the question about |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe Prow Tide configuration now uses separate queries for four release branches and ChangesTide query configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linkvt The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
@linkvt: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mirrors the pattern used by kedacore-keda and other autoscaler projects.
Open question: do we want
jira/valid-referenceon all KEDA related projects similar to as we're doing it in some autoscaler or karpenter related projects? See e.g.release/core-services/prow/02_config/openshift/karpenter-operator/_prowconfig.yaml
Lines 81 to 88 in 5b9a50f
Changes:
Summary by CodeRabbit
kedacore-http-add-onProw Tide configuration.4.22–5.1andmain.verified,backport-risk-assessed, andjira/valid-buglabels.mainrequiresverifiedand uses thekeep-main-query-separateguard.