Skip to content

NO-JIRA: require verified label for kedacore-http-add-on - #83231

Open
linkvt wants to merge 1 commit into
openshift:mainfrom
linkvt:autoscale-add-verified-label-http-addon
Open

NO-JIRA: require verified label for kedacore-http-add-on#83231
linkvt wants to merge 1 commit into
openshift:mainfrom
linkvt:autoscale-add-verified-label-http-addon

Conversation

@linkvt

@linkvt linkvt commented Aug 11, 2026

Copy link
Copy Markdown
Member

Mirrors the pattern used by kedacore-keda and other autoscaler projects.

Open question: do we want jira/valid-reference on all KEDA related projects similar to as we're doing it in some autoscaler or karpenter related projects? See e.g.

- includedBranches:
- main
- master
labels:
- approved
- jira/valid-reference
- lgtm
- verified

Changes:

  • Split single Tide query into branch-specific queries
  • Release branches (4.22-5.1): require verified, backport-risk-assessed, jira/valid-bug
  • main: require verified only, add keep-main-query-separate guard

Summary by CodeRabbit

  • Updates the kedacore-http-add-on Prow Tide configuration.
  • Applies separate merge queries to release branches 4.225.1 and main.
  • Release branches require verified, backport-risk-assessed, and jira/valid-bug labels.
  • main requires verified and uses the keep-main-query-separate guard.

Mirrors the pattern used by kedacore-keda and other autoscaler projects.

Changes:
- Split single Tide query into branch-specific queries
- Release branches (4.22-5.1): require verified, backport-risk-assessed, jira/valid-bug
- main: require verified only, add keep-main-query-separate guard

Signed-off-by: Vincent Link <vlink@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@linkvt: This pull request explicitly references no jira issue.

Details

In response to this:

Mirrors the pattern used by kedacore-keda and other autoscaler projects.

Open question: do we want jira/valid-reference on all KEDA related projects similar to as we're doing it in some autoscaler or karpenter related projects? See e.g.

- includedBranches:
- main
- master
labels:
- approved
- jira/valid-reference
- lgtm
- verified

Changes:

  • Split single Tide query into branch-specific queries
  • Release branches (4.22-5.1): require verified, backport-risk-assessed, jira/valid-bug
  • main: require verified only, add keep-main-query-separate guard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linkvt

linkvt commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

/hold until the question about jira/valid-reference is answered

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e32636e-a8ff-401f-82fd-eb11461c2e56

📥 Commits

Reviewing files that changed from the base of the PR and between 365e2a0 and bd47ea1.

📒 Files selected for processing (1)
  • core-services/prow/02_config/openshift/kedacore-http-add-on/_prowconfig.yaml

Walkthrough

The Prow Tide configuration now uses separate queries for four release branches and main. Each query defines its own required and excluded labels for openshift/kedacore-http-add-on.

Changes

Tide query configuration

Layer / File(s) Summary
Branch-specific Tide rules
core-services/prow/02_config/openshift/kedacore-http-add-on/_prowconfig.yaml
The release query now covers release-4.22, release-4.23, release-5.0, and release-5.1 and requires additional labels. A separate main query requires approved, lgtm, and verified labels and defines missing-label exclusions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • openshift/release#83121 — Both PRs modify Prow Tide configuration queries and label requirements in _prowconfig.yaml files.
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: requiring the verified label for kedacore-http-add-on Tide queries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only a Prow YAML configuration file. It adds no Ginkgo tests or test titles, so stable-name requirements do not apply.
Test Structure And Quality ✅ Passed The pull request changes only one Prow YAML file; it adds no Ginkgo tests or cluster operations, so the listed test-quality requirements do not apply.
Microshift Test Compatibility ✅ Passed The pull request changes only a Prow YAML file; it adds no Ginkgo e2e tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only a Prow YAML configuration file; it adds no Ginkgo e2e tests or test assumptions requiring SNO protection.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only a Prow Tide configuration file with branch and label queries; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only a Prow YAML configuration file. It adds no OTE binary, Go process-level code, or stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only Prow YAML configuration; it adds no Ginkgo e2e tests or networking and external-connectivity code.
No-Weak-Crypto ✅ Passed The PR changes only Prow YAML branch and label queries; the diff contains no weak algorithms, custom cryptography, or secret/token comparisons.
Container-Privileges ✅ Passed The only changed file is a Prow Tide YAML configuration, and it contains no privileged, host namespace, SYS_ADMIN, escalation, or root execution settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only a Tide YAML configuration; added branch and label entries contain no logging calls, credentials, tokens, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Fedosin and joelsmith August 11, 2026 08:23
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 11, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@linkvt: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@linkvt: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants