Skip to content

Kueue downstream ci for s390x - #83236

Draft
Meghagaur wants to merge 4 commits into
openshift:mainfrom
Meghagaur:kueue-oz-s390x
Draft

Kueue downstream ci for s390x#83236
Meghagaur wants to merge 4 commits into
openshift:mainfrom
Meghagaur:kueue-oz-s390x

Conversation

@Meghagaur

@Meghagaur Meghagaur commented Aug 11, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

This PR adds downstream CI support for the Kueue operator release-1.4 on s390x. It configures nightly release inputs, resource requests, and daily downstream end-to-end tests.

It also adds a libvirt-s390x workflow that provisions temporary OpenShift 4.21 clusters on remote IBM Z hypervisors. The workflow includes setup, cleanup, log collection, ownership, and workflow metadata.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @Meghagaur. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Meghagaur
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 76db104e-4c59-4726-85dc-618b7ee91732

📥 Commits

Reviewing files that changed from the base of the PR and between 1948eac and 1b35c38.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/kueue-operator/openshift-kueue-operator-release-1.4-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__libvirt-s390x.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__libvirt-s390x.yaml

Walkthrough

The PR adds a remote s390x libvirt workflow for the Kueue operator and connects it to the release-1.4 OpenShift CI configuration. It also adds workflow ownership and metadata.

Changes

Kueue s390x libvirt CI

Layer / File(s) Summary
Remote libvirt workflow
ci-operator/step-registry/kueue-operator/libvirt-s390x/*
The workflow provisions an ephemeral s390x OpenShift cluster on IBM Z libvirt hypervisors. It adds setup, diagnostics, cleanup, and environment settings.
Release CI integration
ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__libvirt-s390x.yaml, ci-operator/step-registry/kueue-operator/libvirt-s390x/*
The release configuration adds images, release inputs, resource requests, repository metadata, a daily downstream end-to-end test, workflow metadata, and ownership.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Prow
  participant Boskos
  participant KueueOperatorWorkflow
  participant IBMZLibvirtHypervisors
  participant DownstreamE2ETest
  Prow->>Boskos: Allocate libvirt resources
  Prow->>KueueOperatorWorkflow: Start s390x workflow
  KueueOperatorWorkflow->>IBMZLibvirtHypervisors: Provision ephemeral OpenShift cluster
  KueueOperatorWorkflow->>DownstreamE2ETest: Run daily downstream test
  KueueOperatorWorkflow->>IBMZLibvirtHypervisors: Gather logs and clean up resources
Loading

Possibly related PRs


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❓ Inconclusive Tool connection failed before the changed files and OTE-related code could be fully inspected. Retry repository inspection to verify whether this pull request changes any process-level OTE stdout behavior.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Kueue downstream CI changes for the s390x platform.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR adds CI YAML, workflow metadata, and ownership files only; no Ginkgo It, Describe, Context, or When test titles, dynamic or otherwise, are introduced.
Test Structure And Quality ✅ Passed The PR changes only CI YAML, OWNERS, and metadata; no Ginkgo test code, It blocks, or cluster assertions are added or modified.
Microshift Test Compatibility ✅ Passed The patch adds CI configuration, workflow YAML, OWNERS, and metadata only; it adds no Ginkgo e2e tests or test declarations requiring MicroShift API review.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes CI configuration and workflow wiring only; no new Ginkgo It/Describe/Context/When tests or multi-node test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes CI configuration and a libvirt workflow only; they add no operator manifests, controllers, replicas, affinity, topology spread, selectors, or PDB scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes CI YAML and metadata only; it adds no Ginkgo test declarations or test code with IPv4 assumptions or external connectivity.
No-Weak-Crypto ✅ Passed The checked-out patch only changes the cluster profile labels. No MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons are added.
Container-Privileges ✅ Passed The four added files contain no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root securityContext declarations; capabilities: intranet is a job capability.
No-Sensitive-Data-In-Logs ✅ Passed The added YAML and metadata contain no credentials, tokens, PII, or log statements; they only reference standard gather steps and a job-log URL.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sivaramsingana

Copy link
Copy Markdown

/ok-to-test

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@sivaramsingana: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@veera-damisetti

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@bj2122

bj2122 commented Aug 11, 2026

Copy link
Copy Markdown

/ok-to-test

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Meghagaur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-images openshift/kueue-operator presubmit Presubmit changed
periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Meghagaur

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Meghagaur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Meghagaur

Copy link
Copy Markdown
Author

/ok-to-test

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@Meghagaur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22 1b35c38 link unknown /pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22
ci/prow/config 1b35c38 link true /test config

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants