Skip to content

New periodic job for testing ARO-HCP on OCP 5.0 - #83253

Open
miquelsi wants to merge 1 commit into
openshift:mainfrom
miquelsi:aro-hcp-ocp-5
Open

New periodic job for testing ARO-HCP on OCP 5.0#83253
miquelsi wants to merge 1 commit into
openshift:mainfrom
miquelsi:aro-hcp-ocp-5

Conversation

@miquelsi

@miquelsi miquelsi commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

New periodic job for testing ARO-HCP on OCP 5.0

Summary by CodeRabbit

Adds a weekly production periodic job to test ARO-HCP on OCP 5.0. The job runs the parallel end-to-end workflow with production configuration and a four-hour timeout.

Updates the persistent ARO-HCP test step to select OpenShift control-plane and node-pool versions independently.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @miquelsi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from janboll and mmazur August 11, 2026 12:30
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miquelsi
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 9aef76b9-0b41-4bee-8054-aafbc871cbfd

📥 Commits

Reviewing files that changed from the base of the PR and between 46c71d1 and 3ca198a.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
  • ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
  • ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-ref.yaml

Walkthrough

The PR adds separate ARO-HCP control-plane and node-pool version variables. It also schedules a weekly production parallel E2E job pinned to candidate version 5.0.0-ec.5.

Changes

ARO-HCP candidate E2E workflow

Layer / File(s) Summary
Version selection and production scheduling
ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-ref.yaml, ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
The persistent test step defines separate control-plane and node-pool version variables. The periodic configuration adds a Sunday production parallel E2E job with candidate channels, production subscriptions and Vault settings, production reporting, and a four-hour timeout.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mmazur, janboll

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a periodic ARO-HCP test job for OCP 5.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only YAML CI configuration and step metadata; the diff adds no Ginkgo It, Describe, Context, or When calls, and no dynamic test titles.
Test Structure And Quality ✅ Passed The commit changes only three CI YAML files; no Ginkgo It blocks, setup/cleanup hooks, cluster waits, or assertions were added or modified.
Microshift Test Compatibility ✅ Passed The pull request changes only CI YAML files and adds no Ginkgo e2e tests or test declarations, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only CI YAML and step metadata; no new Ginkgo tests or multi-node test logic were added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The commit adds CI job configuration, a generated Prow job, and version environment variables; it adds no affinity, topology spread, node selectors, tolerations, replicas, or PDB scheduling constra...
Ote Binary Stdout Contract ✅ Passed The commit changes only three YAML files; no OTE process-level source or stdout write was added, and the external binary is only invoked by an unchanged shell wrapper.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit adds only periodic-job and environment YAML; it adds no Ginkgo test declarations or network literals, and the job invokes the existing persistent suite.
No-Weak-Crypto ✅ Passed The pull request adds YAML job configuration and version environment variables only; scans of all added lines and changed files found no weak crypto or secret-comparison code.
Container-Privileges ✅ Passed The added job and step-reference YAML contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or explicit root settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only channel/version selectors and references to mounted secret files; it adds no credential values or logging, and credential tracing remains disabled during Azure login.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janboll

janboll commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@miquelsi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-stable Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-fast Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-nightly Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-stable Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-fast Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-nightly Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-stable Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-fast Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-nightly Azure/ARO-HCP presubmit Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-slow N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel-slow N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel-ocp-nightly N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-nightly N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel-westus3 N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0 N/A periodic Periodic changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@miquelsi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0 3ca198a link unknown /pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants