OCPBUGS-105871: For azure-kubernetes-kms swaping AWS e2e workflow with Azure AKS e2e workflow - #83320
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@PoornimaSingour: This pull request references Jira Issue OCPBUGS-105871, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (22)
📒 Files selected for processing (22)
🚧 Files skipped from review as they are similar to previous changes (22)
WalkthroughThe Azure Kubernetes KMS configurations add the ChangesAzure AKS HyperShift configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@PoornimaSingour: This pull request references Jira Issue OCPBUGS-105871, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.0-e2e-hypershift |
|
@csrwng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.0-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…ubernetes-kms configs
c9488c9 to
cfa8a7d
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.1-e2e-hypershift, pull-ci-openshift-azure-kubernetes-kms-release-5.0-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ci/rehearse/openshift/azure-kubernetes-kms/release-5.0/e2e-hypershift |
|
@PoornimaSingour: job(s): pull-ci-openshift-azure-kubernetes-kms-release-5.1-e2e-hypershift, either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.1-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): ci/rehearse/openshift/azure-kubernetes-kms/release-5.0/e2e-hypershift either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse ci/rehearse/openshift/azure-kubernetes-kms/release-5.0/e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): ci/rehearse/openshift/azure-kubernetes-kms/release-5.0/e2e-hypershift either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.0-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.1-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-5.1-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-4.22-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-4.23-e2e-hypershift,pull-ci-openshift-azure-kubernetes-kms-release-4.21-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: job(s): pull-ci-openshift-azure-kubernetes-kms-release-4.23-e2e-hypershift,pull-ci-openshift-azure-kubernetes-kms-release-4.21-e2e-hypershift either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-4.23-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse list |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 50 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-azure-kubernetes-kms-release-4.21-e2e-hypershift |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@PoornimaSingour: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, PoornimaSingour The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
Verified by pj-rehearse
|
|
/pj-rehearse ack |
|
@PoornimaSingour: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@PoornimaSingour: Jira Issue OCPBUGS-105871: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-105871 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
Summary
The azure-kubernetes-kms repo CI configuration was incorrectly using the AWS HyperShift e2e workflow
(
hypershift-aws-e2e-externalwithhypershift-awscluster profile) instead of the Azure AKS e2e workflow. This meant e2e tests were provisioning an AWS HyperShift cluster and validating AWS KMS encryption, not Azure KMS encryption.Changes
cluster_profilefromhypershift-awstohypershift-aksacross all config filesworkflowfromhypershift-aws-e2e-externaltohypershift-azure-aks-e2eacross all config filesopenshift/azure-kubernetes-kmsandopenshift-priv/azure-kubernetes-kms(22 config files + 22 generated job files = 44 files total)Affected configs
ci-operator/config/openshift/azure-kubernetes-kms/— main + release-4.16 through release-5.1 (11 files)ci-operator/config/openshift-priv/azure-kubernetes-kms/— main + release-4.16 through release-5.1 (11 files)JIRA
https://issues.redhat.com/browse/OCPBUGS-105871
Related
Identified in openshift/azure-kubernetes-kms#52
Summary by CodeRabbit
The PR updates
azure-kubernetes-kmsCI configurations in the public and private repositories. It movese2e-hypershifttests from AWS HyperShift to Azure AKS for the main and release 4.16 through 5.1 configurations.The configurations now use:
hypershift-akshypershift-azure-aks-e2ehypershift-operatorCertificate authentication is enabled. The selected test filters remain unchanged.