[libvirt_manager] Add parent_group key for libvirt layouts#3925
Conversation
|
Skipping CI for Draft Pull Request. |
nemarjan
left a comment
nemarjan
left a comment
There was a problem hiding this comment.
LGTM in general, just some questions.
michburk
force-pushed
the
libvirt-parent-groups
branch
from
9fbc705 to
35a87eb
Compare
michburk
force-pushed
the
libvirt-parent-groups
branch
from
35a87eb to
62f4064
Compare
|
Also added a check to the My testing used two child VM types (compute94 and compute96) both setting parent_group: computes, with no Nemanja's comment prompted me to test a layout with both a regular |
michburk
force-pushed
the
libvirt-parent-groups
branch
2 times, most recently
from
d202b36 to
8a9d4a5
Compare
michburk
force-pushed
the
libvirt-parent-groups
branch
from
8a9d4a5 to
3ff2f09
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 24s |
|
recheck |
michburk
force-pushed
the
libvirt-parent-groups
branch
from
3ff2f09 to
ec67224
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 6m 31s |
michburk
force-pushed
the
libvirt-parent-groups
branch
3 times, most recently
from
5c83861 to
4cf077d
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 16m 14s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 23m 56s |
|
recheck |
michburk
force-pushed
the
libvirt-parent-groups
branch
2 times, most recently
from
7c13c92 to
372a52f
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 29m 30s |
michburk
force-pushed
the
libvirt-parent-groups
branch
from
372a52f to
ce3761e
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 50m 05s |
michburk
force-pushed
the
libvirt-parent-groups
branch
7 times, most recently
from
24316c2 to
c179401
Compare
michburk
force-pushed
the
libvirt-parent-groups
branch
2 times, most recently
from
99532e0 to
ff0954a
Compare
Allow VM types to declare a parent_group so that multiple subgroups (e.g. compute1, compute2) are independently addressable while also being reachable via a shared parent inventory group (e.g. computes). Generated-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Michael Burke <michburk@redhat.com>
michburk
force-pushed
the
libvirt-parent-groups
branch
from
ff0954a to
d21adfe
Compare
| {{ _names }} | ||
| _reserved_groups: | ||
| - hypervisors | ||
| - localhosts |
There was a problem hiding this comment.
(non-blocking) suggestion: Maybe for a following patch, but It'd be good to have here crcs.
It seems it won't collide if: "parent_ansible_group: crcs" as crc goes to ocps
But I'd not stop merging this and need to run the hwole tests again
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Valkyrie00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 5de0766
into
openstack-k8s-operators:main
4 participants
Allow VM types to declare a parent_group so that multiple subgroups (e.g. compute1, compute2) are independently addressable while also being reachable via a shared parent inventory group (e.g. computes).