When a course is renamed update the LTI course map for the course.#2826
Merged
somiaj merged 1 commit intoopenwebwork:developfrom Feb 1, 2026
Merged
Conversation
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
2 times, most recently
from
abf3f09 to
afdf319
Compare
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
2 times, most recently
from
7f66fe3 to
1b9ab15
Compare
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
from
1b9ab15 to
aa17574
Compare
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
2 times, most recently
from
117d648 to
8d73efb
Compare
Alex-Jordan
approved these changes
Dec 19, 2025
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
from
8d73efb to
12a7eb5
Compare
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
3 times, most recently
from
006ba5c to
3216e38
Compare
This deletes the course map entry for the course's previous name, and then creates a new entry for the course's new name. Since the `renameCourse` method is also used when unarchiving a course to a different name, care needs to be taken to ensure that this is only done for a course rename, and not for that situation. Thus there is a new `updateLTICourseMap` option for the method. This is only true when the method is called to rename a course directly. This addresses issue openwebwork#2824.
drgrice1
force-pushed
the
course-rename-update-lti-course-map
branch
from
3216e38 to
57938a8
Compare
Contributor
|
Same thing here, I'll approve and merge but cannot test. I am trusting that it has been tested. |
somiaj
approved these changes
Feb 1, 2026
Contributor
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
Code is straight forward that it looks like it should do what is described. Again I couldn't actually test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deletes the course map entry for the course's previous name, and then creates a new entry for the course's new name.
Since the
renameCoursemethod is also used when unarchiving a course to a different name, care needs to be taken to ensure that this is only done for a course rename, and not for that situation. Thus there is a newupdateLTICourseMapoption for the method. This is only true when the method is called to rename a course directly.This addresses issue #2824.