Improvements for the problem renderer on the problem grader page.#2865
Open
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Open
Improvements for the problem renderer on the problem grader page.#2865drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
drgrice1 wants to merge 1 commit intoopenwebwork:developfrom
Conversation
drgrice1
force-pushed
the
problem-grader-answers
branch
3 times, most recently
from
0e9f9e4 to
dad7cc0
Compare
drgrice1
force-pushed
the
problem-grader-answers
branch
3 times, most recently
from
407018d to
3476866
Compare
drgrice1
force-pushed
the
problem-grader-answers
branch
from
3476866 to
2c32c3e
Compare
drgrice1
force-pushed
the
problem-grader-answers
branch
from
2c32c3e to
55c1389
Compare
First, this makes it so that feedback is shown on initial render. This occurs both on initial page load (for the initially selected user), and also occurs when a different user is selected from the dropdown. Second, this fixes some issues with tests and answers. The test answer prefix needs to be preserved in the form so that checking answers works. Also, the `ProblemGrader.html.ep` template was constructing the quiz prefix from the problem number and should be using the `problem_id` (which is what the GatewayQuiz.pm module uses). That means the last answers were not working at all for tests with random problem order.
drgrice1
force-pushed
the
problem-grader-answers
branch
from
55c1389 to
44187c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, this makes it so that feedback is shown on initial render. This occurs both on initial page load (for the initially selected user), and also occurs when a different user is selected from the dropdown.
Second, this fixes some issues with tests and answers. The test answer prefix needs to be preserved in the form so that checking answers works. Also, the
ProblemGrader.html.eptemplate was constructing the quiz prefix from the problem number and should be using theproblem_id(which is what the GatewayQuiz.pm module uses). That means the last answers were not working at all for tests with random problem order.