Fix grading proctored tests that require proctor authorization to do so.#2968
Open
drgrice1 wants to merge 1 commit intoopenwebwork:WeBWorK-2.21from
Open
Fix grading proctored tests that require proctor authorization to do so.#2968drgrice1 wants to merge 1 commit intoopenwebwork:WeBWorK-2.21from
drgrice1 wants to merge 1 commit intoopenwebwork:WeBWorK-2.21from
Conversation
The `can_recordAnswers` method of the `WeBWorK::ContentGenerator::GatewayQuiz` package can not call any of the `WeBWorK::ContentGenerator::GatewayQuiz` methods because it is called directly by the `WeBWorK::ContentGenerator::LoginProctor` module without a `WeBWorK::ContentGenerator::GatewayQuiz` object. Attempting to do so will cause an exception. This is a bit annoying as the conditions of the `can_gradeUnsubmittedTest` method (including the conditions of the `can_showProblemGrader` method it calls) must be directly used by the `can_recordAnswers` method. There is no way around that though. This definitely should be considered for a hotfix.
drgrice1
force-pushed
the
bugfix/gateway-test-proctor-grade
branch
from
91647a8 to
a137f24
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
can_recordAnswersmethod of theWeBWorK::ContentGenerator::GatewayQuizpackage can not call any of theWeBWorK::ContentGenerator::GatewayQuizmethods because it is called directly by theWeBWorK::ContentGenerator::LoginProctormodule without aWeBWorK::ContentGenerator::GatewayQuizobject. Attempting to do so will cause an exception.This is a bit annoying as the conditions of the
can_gradeUnsubmittedTestmethod (including the conditions of thecan_showProblemGradermethod it calls) must be directly used by thecan_recordAnswersmethod. There is no way around that though.This definitely should be considered for a hotfix.