🌱 Apply cluster TLS profile to outgoing HTTP client#2767
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Applies the cluster’s configured TLS profile to the outgoing HTTP client so catalogd’s client behavior matches the TLS configuration approach used elsewhere (e.g., metrics server), while keeping a TLS 1.2 minimum as a fallback.
Changes:
- Import TLS profile helper and apply it to the HTTP client TLS config when available.
- Retain TLS 1.2 minimum as the default baseline.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2767 +/- ##
==========================================
- Coverage 66.78% 66.76% -0.03%
==========================================
Files 149 149
Lines 11382 11386 +4
==========================================
Hits 7602 7602
- Misses 3221 3223 +2
- Partials 559 561 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tmshort
force-pushed
the
use-tls-profile-for-client
branch
from
df8aa6b to
79f5990
Compare
Use the configured TLS profile (set via --tls-profile flags) for the catalogd HTTP client, consistent with how the metrics server TLS is configured. Falls back to TLS 1.2 minimum when no profile is set. Signed-off-by: Todd Short <tshort@redhat.com>
tmshort
force-pushed
the
use-tls-profile-for-client
branch
from
79f5990 to
2e77886
Compare
|
/approve |
|
@perdasilva: Overrode contexts on behalf of perdasilva: codecov/patch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Use the configured TLS profile (set via --tls-profile flags) for the catalogd HTTP client, consistent with how the metrics server TLS is configured. Falls back to TLS 1.2 minimum when no profile is set.
Description
Reviewer Checklist