Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in the Node.js implementation where clientEnging was misspelled instead of clientEngine, and adds proper TypeScript typing by importing and using the OptimizelyFactoryConfig type.
- Fixed typo:
clientEnging→clientEnginein the Node.js configuration - Added proper TypeScript typing for configuration objects in both React Native and Node.js implementations
- Imported
OptimizelyFactoryConfigtype to ensure type safety
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/index.react_native.ts | Added OptimizelyFactoryConfig import and type annotation for rnConfig |
| lib/index.node.ts | Added OptimizelyFactoryConfig import, type annotation for nodeConfig, and fixed clientEnging typo |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
junaed-optimizely
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues