cockpit: Show registration for image mode (HMS-10093)

[regexowl]

Since distribution can be undefined, it doesn't pass the isRhel check and the step with its review was incorrectly hidden when in image mode.

JIRA: HMS-10093

[regexowl]

/jira-epic HMS-9973

[coderabbitai]

Warning

Rate limit exceeded

@regexowl has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sourcery-ai]

Hey - I've left some high level feedback:

• The conditions for showing the registration section differ between the wizard step (isImageMode) and the review step (`blueprintMode === 'image'); consider centralizing this logic in a shared helper or using a single source of truth for 'image mode' to avoid future divergence.
• Given distribution can be undefined, it may be clearer to make that explicit in the isRhel check or wrapper (e.g., a shouldShowRegistration(distribution, mode) helper) rather than relying on the falsy behavior of isRhel(distribution) in multiple places.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The conditions for showing the registration section differ between the wizard step (`isImageMode`) and the review step (`blueprintMode === 'image'); consider centralizing this logic in a shared helper or using a single source of truth for 'image mode' to avoid future divergence.
- Given `distribution` can be undefined, it may be clearer to make that explicit in the `isRhel` check or wrapper (e.g., a `shouldShowRegistration(distribution, mode)` helper) rather than relying on the falsy behavior of `isRhel(distribution)` in multiple places.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.78%. Comparing base (fe303d2) to head (f2db06c).
⚠️ Report is 55 commits behind head on main.

@@           Coverage Diff           @@
##             main    #4024   +/-   ##
=======================================
  Coverage   73.77%   73.78%           
=======================================
  Files         207      207           
  Lines        7729     7731    +2     
  Branches     2651     2652    +1     
=======================================
+ Hits         5702     5704    +2     
  Misses       1775     1775           
  Partials      252      252           

Files with missing lines	Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx	90.81% <100.00%> (+0.04%)	⬆️
...ents/CreateImageWizard/steps/Review/ReviewStep.tsx	88.15% <100.00%> (+0.07%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe303d2...f2db06c. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[kingsleyzissou]

I need to look into this a bit, I'm not 100% sure we support registration for bootc... and if we do, I'm not 100% sure yet if we propagated this all the way into image-builder-cli and bootc-image-builder

[regexowl]

I need to look into this a bit, I'm not 100% sure we support registration for bootc... and if we do, I'm not 100% sure yet if we propagated this all the way into image-builder-cli and bootc-image-builder

Got it, I was just blindly following the customization list in https://issues.redhat.com/browse/HMS-10021, didn't check if the registration really works 😅

If this stays hidden, there will be one more crash when trying to visit FSC step in edit mode. That one was solved by @ochosi on PF side patternfly/patternfly-react#12166, we're waiting for release so the dep can be bumped.

[regexowl]

#4044 changes the logic of filtering steps. If we ever need this, we should implement it in an up-to-date way. Closing this one.