fix: update lz4 pattern for android (#5441) #5448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackulau
force-pushed
the
5441_liblz4
branch
from
d52bb95 to
c264e0d
Compare
Add pattern to detect lz4 version in Android libraries where the version string format differs from standard Linux binaries. - Add FILENAME_PATTERNS to match liblz4 library files - Add VERSION_PATTERN to match Android format where version appears between ERROR_* strings (works across API 30 and API 34) - Add test cases for Android lz4 format (API 30: 1.8.3, API 34: 1.9.4) Partial fix for ossf#5441 Signed-off-by: Jack <[email protected]>
Add pattern to detect lz4 version in Android libraries. - Add FILENAME_PATTERNS to match liblz4 library files - Update VERSION_PATTERN to handle null byte separators (API 28) - Add generic ERROR_* pattern for API 30/34 format - Add test cases for Android lz4 formats Tested on Android API 28, 29, 30, 34 Partial fix for ossf#5441 Signed-off-by: Jack <[email protected]>
jackulau
force-pushed
the
5441_liblz4
branch
from
2c893d7 to
24237e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add pattern to detect lz4 version in Android libraries.
Changes
FILENAME_PATTERNSto matchliblz4library filesVERSION_PATTERNfor Android format:ERROR_srcPtr_wrong-> version ->ERROR_frameType_unknown