[TECHNICAL] Resource leaks in fragment bindings

[corevibe555]

Related Issues

Fixes #4813

Description

Set _binding = null in onDestroyView() for 10 fragments that were missing cleanup, preventing memory leaks when fragment instances outlive their views.

Affected fragments:

• CreateShortcutDialogFragment
• FileDetailsFragment
• MainEmptyListFragment
• RemoveFilesDialogFragment
• SharesFragment
• SpacesListFragment
• CreateSpaceDialogFragment
• AddMemberFragment
• SpaceMembersFragment
• SetSpaceIconDialogFragment

App:

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

• Verify app builds without errors
• Navigate in and out of each affected fragment and confirm no crashes

[corevibe555]

@joragua Here is another small PR.
Would you please review when you have a chance?

Thanks!

[joragua]

Thanks for the contribution @corevibe555! 🙌🏻 I will check this PR as soon as possible and give you any feedback if necessary. Stay tuned!

[joragua]

Nice job @corevibe555! 🍻 Some comments about this PR

1. I'd split this into two separate commits: one for the calens entry (chore: add calens file or chore: add changelog) and another one for the implementation (keeping the same name)

2. Regarding changelog file: missing PR link at the end of the file. In addition, the name of the file must be the PR id (in this case: 4814)

3. After rebasing the branch against master, there are more fragments that need binding cleanup. Also, there is an extra point in this PR: onDestroy() methods that only handle binding cleanup should be replaced with onDestroyView(). There are three fragments currently clearing the binding in onDestroy(): TransfersListFragment, SortBottomSheetFragment, and MainFileListFragment

[corevibe555]

@joragua I really appreciated by your feedback :)
My updates:

1. Splitted commit into 2(original commit and one more commit for calens entry)
2. Changed name of changelog file(to 4814), added missing PR link.
3. Rebased against master, added 3 more enhancements for
   TransferListFragment
   SortBottomSheetFragment
   MainFileListFragment

[corevibe555]

@joragua Would you possibly review this PR when you have a chance?
Thanks you!

[joragua]

Hi @corevibe555! One more comment and it's ready 😄

I'd split this into two separate commits: one for the calens entry (chore: add calens file or chore: add changelog) and another one for the implementation (keeping the same name)

Regarding the comment above, I’d choose only one of the suggestions for the changelog commit, not both:

1. chore: add calens file
2. chore: add changelog

Choose one of these! Up to you! 🙌🏻

[corevibe555]

That was my bad.
Fixed now.