Skip to content

feat: add index for foreign keys - #5005

Merged
jesmrec merged 3 commits into
masterfrom
technical/hannesa2_add_index_for_foreign_keys
Oct 7, 2026
Merged

jesmrec merged 3 commits into
masterfrom
technical/hannesa2_add_index_for_foreign_keys

Conversation

@jesmrec

@jesmrec jesmrec commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

follow up from #4972

Fixes #4971

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec
jesmrec marked this pull request as ready for review October 5, 2026 08:10
@jesmrec
jesmrec requested a review from a team as a code owner October 5, 2026 08:10
@hannesa2

hannesa2 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Is this now better
image
compared to my previous one ?
image
Sorry, I don't get it

@jesmrec jesmrec closed this Oct 5, 2026
@jesmrec jesmrec reopened this Oct 5, 2026
@jesmrec

jesmrec commented Oct 5, 2026 •

Copy link
Copy Markdown
Member Author

@hannesa2 the difference is in the GithHub's list of commits, since is GitHub the PGP/GPG validator

Current PR:

Screenshot 2026-10-05 at 10 39 24

Your PR:

Screenshot 2026-10-05 at 10 39 00

you just have to add your key to your personal github's key container

@jesmrec
jesmrec force-pushed the technical/hannesa2_add_index_for_foreign_keys branch from f54efea to d6b72c8 Compare October 5, 2026 11:46

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment about calens and it's ready to go 💯

Comment thread changelog/unreleased/5005 Outdated
Comment thread changelog/unreleased/5005 Outdated
@jesmrec
jesmrec force-pushed the technical/hannesa2_add_index_for_foreign_keys branch from d6b72c8 to 5d2c649 Compare October 7, 2026 07:48
@jesmrec
jesmrec requested a review from joragua October 7, 2026 07:48
joragua
joragua previously approved these changes Oct 7, 2026

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Moving it to QA 🚀

Comment thread owncloudData/schemas/com.owncloud.android.data.OwncloudDatabase/50.json Outdated
@jesmrec
jesmrec force-pushed the technical/hannesa2_add_index_for_foreign_keys branch from 5d2c649 to affab80 Compare October 7, 2026 11:58
Signed-off-by: Hannes Achleitner <hannes.software@gmx.at>
Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec
jesmrec force-pushed the technical/hannesa2_add_index_for_foreign_keys branch from affab80 to cefce10 Compare October 7, 2026 12:54
Signed-off-by: Jesus Recio <jrecio@izertis.com>
Signed-off-by: Jesus Recio <jrecio@izertis.com>
@jesmrec
jesmrec force-pushed the technical/hannesa2_add_index_for_foreign_keys branch from cefce10 to 67ab305 Compare October 7, 2026 12:59
@jesmrec
jesmrec requested review from hannesa2 and joragua October 7, 2026 13:04
@joragua joragua changed the title fix: add index for foreign keys feat: add index for foreign keys Oct 7, 2026
@jesmrec

jesmrec commented Oct 7, 2026 •

Copy link
Copy Markdown
Member Author

CI, tests and E2E passed.

Moving on.

Thanks @hannesa2 for another contribution!

@jesmrec
jesmrec merged commit 0d6c955 into master Oct 7, 2026
11 checks passed
@jesmrec
jesmrec deleted the technical/hannesa2_add_index_for_foreign_keys branch October 7, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECHNICAL] CI shows performance issues with Room

3 participants