Remove OC10SyncRoot #12422
Remove OC10SyncRoot #12422
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
erikjv
force-pushed
the
work/remove-OC10SyncRoot
branch
from
feb6a6c to
31eb186
Compare
erikjv
force-pushed
the
work/remove-OC10SyncRoot
branch
2 times, most recently
from
d1d723a to
1b4d322
Compare
erikjv
force-pushed
the
work/remove-OC10SyncRoot
branch
3 times, most recently
from
d6059ec to
275d3bf
Compare
erikjv
force-pushed
the
work/remove-OC10SyncRoot
branch
from
275d3bf to
f0c3828
Compare
Also simplify the path validity checks.
erikjv
force-pushed
the
work/remove-OC10SyncRoot
branch
from
f0c3828 to
30c343f
Compare
| /** | ||
| * @brief Check a path for validity. | ||
| * | ||
| * We do not allow putting a folder inside another folder that is already syncing to a server. We also disallow a space to be put into the default sync root |
There was a problem hiding this comment.
what does this return value mean/contain?
also "we disallow a space to be put into the default sync root" - maybeI am misreading this, but this is precisely what the default sync root is for - for adding local folders per space. maybe..."we disallow using the sync root as the local path for a new space folder" is more specific?
also please move the "docs" from the cpp for this function to here in the header
|
|
||
| const QString userDir = QDir::cleanPath(canonicalPath(path)) + QLatin1Char('/'); | ||
| for (auto f : folders()) { | ||
| for (auto f : FolderMan::instance()->folders()) { |
There was a problem hiding this comment.
these "static" functions that use member info (via instance()) should not be static.
| return checkPathValidityRecursive(path, folderType, accountUuid); | ||
| } | ||
|
|
||
| QString FolderMan::checkPathValidityRecursive(const QString &path, NewFolderType folderType, const QUuid &accountUuid) |
There was a problem hiding this comment.
rename this for clarity - it is really looking for the first existing folder in the parent hierarchy
No description provided.