test(vscode): longer sleep for empty oxlint config test#17027
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR addresses a flaky test by making the sleep duration configurable in test helper functions and increasing the wait time for the "empty oxlint configuration" test from 250ms to 500ms.
- Made
sleepDurationan optional parameter in test helper functions with a default of 250ms - Re-enabled the "empty oxlint configuration" test that was previously skipped due to flakiness
- Applied a longer 500ms sleep duration to the re-enabled test
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| editors/vscode/tests/test-helpers.ts | Added optional sleepDuration parameter to getDiagnostics and getDiagnosticsWithoutClose functions to allow customizable wait times |
| editors/vscode/tests/e2e_server_linter.spec.ts | Re-enabled the "empty oxlint configuration" test with a 500ms sleep duration to reduce flakiness |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
66dce6b to
938f23b
Compare

No description provided.