Skip to content

test(vscode): longer sleep for empty oxlint config test#17027

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-18-test_vscode_longer_sleep_for_empty_oxlint_config_test
Dec 19, 2025
Merged

test(vscode): longer sleep for empty oxlint config test#17027
graphite-app[bot] merged 1 commit intomainfrom
12-18-test_vscode_longer_sleep_for_empty_oxlint_config_test

Conversation

@Sysix
Copy link
Copy Markdown
Member

@Sysix Sysix commented Dec 17, 2025

No description provided.

Copy link
Copy Markdown
Member Author

Sysix commented Dec 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 17, 2025
@camc314 camc314 self-assigned this Dec 18, 2025
@Sysix Sysix marked this pull request as ready for review December 19, 2025 12:05
Copilot AI review requested due to automatic review settings December 19, 2025 12:05
@Sysix Sysix requested a review from camc314 as a code owner December 19, 2025 12:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a flaky test by making the sleep duration configurable in test helper functions and increasing the wait time for the "empty oxlint configuration" test from 250ms to 500ms.

  • Made sleepDuration an optional parameter in test helper functions with a default of 250ms
  • Re-enabled the "empty oxlint configuration" test that was previously skipped due to flakiness
  • Applied a longer 500ms sleep duration to the re-enabled test

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
editors/vscode/tests/test-helpers.ts Added optional sleepDuration parameter to getDiagnostics and getDiagnosticsWithoutClose functions to allow customizable wait times
editors/vscode/tests/e2e_server_linter.spec.ts Re-enabled the "empty oxlint configuration" test with a 500ms sleep duration to reduce flakiness

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Copy link
Copy Markdown
Member Author

Sysix commented Dec 19, 2025

Merge activity

@graphite-app graphite-app Bot force-pushed the 12-18-test_vscode_longer_sleep_for_empty_oxlint_config_test branch from 66dce6b to 938f23b Compare December 19, 2025 12:10
@graphite-app graphite-app Bot merged commit 938f23b into main Dec 19, 2025
19 checks passed
@graphite-app graphite-app Bot deleted the 12-18-test_vscode_longer_sleep_for_empty_oxlint_config_test branch December 19, 2025 12:15
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants