refactor(formatter): remove unnecessary clone for experimental_sort_imports option#17065
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 19, 2025
Conversation
github-actions
Bot
added
A-formatter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #17065 will not alter performanceComparing Summary
Footnotes
|
Dunqing
force-pushed
the
12-18-refactor_formatter_remove_unnecessary_clone_for_experimental_sort_imports_option
branch
from
1d8cd3c to
8c6fa17
Compare
Dunqing
force-pushed
the
12-18-refactor_formatter_move_the_parsing_group_for_sorting_imports_to_the_place_where_it_is_used
branch
from
bc2dc61 to
ea7cbec
Compare
Dunqing
changed the title
experimental_sort_imports option
leaysgur
approved these changes
Dec 19, 2025
Member
Merge activity
|
…imports` option (#17065) Remove the unnecessary clone, since `experimental_sort_imports` is a complex struct that is not cheap to clone. I also removed `apply_transform` to avoid a borrow checker problem, as it borrows `&mut self`, and there is already an immutable reference borrowed by `formatted.context().options().experimental_sort_imports`.
graphite-app
Bot
force-pushed
the
12-18-refactor_formatter_move_the_parsing_group_for_sorting_imports_to_the_place_where_it_is_used
branch
from
ea7cbec to
297eb09
Compare
graphite-app
Bot
force-pushed
the
12-18-refactor_formatter_remove_unnecessary_clone_for_experimental_sort_imports_option
branch
from
8c6fa17 to
853f659
Compare
Base automatically changed from
12-18-refactor_formatter_move_the_parsing_group_for_sorting_imports_to_the_place_where_it_is_used
to
main
December 19, 2025 01:25
graphite-app
Bot
deleted the
12-18-refactor_formatter_remove_unnecessary_clone_for_experimental_sort_imports_option
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary clone, since
experimental_sort_importsis a complex struct that is not cheap to clone. I also removedapply_transformto avoid a borrow checker problem, as it borrows&mut self, and there is already an immutable reference borrowed byformatted.context().options().experimental_sort_imports.