fix printf-related go vet violations#46
Merged
iliana merged 1 commit intorelease-22.1-oxidefrom Feb 27, 2026
Merged
Conversation
sudomateo
reviewed
Feb 27, 2026
sudomateo
left a comment
sudomateo
left a comment
There was a problem hiding this comment.
Left one suggestion based on what I thought the code should look like. Everything else looks good!
sudomateo
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Go 1.24, the
printfanalyzer ingo vetwas improved to catch cases where the format string is a non-const string. This is a pretty strong code smell and I think qualifies as worth changing despite wanting to avoid code churn -- the code is fundamentally wrong.There's a few additional cases found in newer versions of Go where the format string specifier and the type of the value being formatted don't match. These cases deserve some extra scrutiny during review, particularly since I am not fluent in Go.
This is split out from the Go 1.26 PR I'm working on, since it can be applied any time.