Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10.
The primary exciting change here is the removal of unsafe
//go:linknamedirectives frompkg/util/goschedstats; Go 1.26 introduces the/sched/goroutines/runnable:goroutinesruntime metric. This should make future toolchain updates significantly less complex and worrysome.golang.org/x/toolsneeded to be updated to 0.39.0 due to a protocol change betweengo vetand the underlying analysis library used by roachvet. This brought in a newergolang.org/x/crypto, which changed an error string related to bcrypt.RSA keys generated during testing needed to be upgraded from 512 bits to 1024 bits due to a new minimum requirement in
crypto/rsa.In draft state because we're using the binary release from go.dev for illumos. Helios v3 has 1.26.0. We may want to backport those changes to Helios v2 or accept this and revert the CI changes when we move to Helios v3.