Remove discoverable from silo create and silo list - #3392
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
remove-discoverable
branch
from
September 22, 2026 15:20
c3c5dbb to
9f5b32c
Compare
david-crespo
force-pushed
the
remove-discoverable
branch
from
September 22, 2026 18:54
9f5b32c to
6d04e53
Compare
david-crespo
changed the title
discoverable from silo create and silo list
Contributor
|
Looks like we can delete app/table/cells/BooleanCell.tsx since it isn't used anywhere now |
Collaborator
Author
|
Test failure is a flake, will merge on re-run. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following oxidecomputer/omicron#11296
I didn't realize this, but the discoverable column on the table has always been pointless because the list would never contain any non-discoverable ones — this is the entire point of the discoverable flag. So I removed it from the table. There can still be non-discoverable silos in existing systems, but removing this column doesn't change anything about the operator's ability to find them.
🤖 Why the silos list can never contain a non-discoverable silo
The external
silo_listendpoint goes throughNexus::silos_list, which hardcodesDiscoverability::DiscoverableOnlywith no role-based override (nexus/src/app/silo.rs#L175), and the datastore turns that into adiscoverable = truefilter (nexus/db-queries/src/db/datastore/silo.rs#L397). Non-discoverable silos may exist on real systems, both the recovery silo created during rack setup (nexus/db-queries/src/db/datastore/rack.rs#L465) and any created through the API before omicron#11296 removed the field, but they are hidden from the list regardless, so a column there carries no information.