Repository navigation
fix OpenAPI nullability for Option<T> request and response bodies - #1751
Merged
Conversation
sunshowers
changed the base branch from
sunshowers/spr/main.fix-openapi-nullability-for-optiont-request-and-response-bodies
to
sunshowers/spr/add-tests-showing-nullability-dropped-for-optiont-bodies
October 27, 2026 23:51
ahl
approved these changes
Oct 29, 2026
| reference: reference.clone(), | ||
| let reference = | ||
| openapiv3::ReferenceOr::Reference { reference: reference.clone() }; | ||
| if schema_object_is_nullable(obj) { |
Collaborator
There was a problem hiding this comment.
Note that in this situation schemars should NOT be decorating a schema with extensions since it's not valid OpenAPI v3.0.x -- but it is.
Collaborator
Author
There was a problem hiding this comment.
Yep. Discussed privately in chat, and added a comment about this.
sunshowers
deleted the
sunshowers/spr/fix-openapi-nullability-for-optiont-request-and-response-bodies
branch
October 29, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the comment for more details.
This was found while working on trust quorum for RFD 747. In omicron main, Sled
Agent's
GET /trust-quorum/coordinator-statusreturns anOption<CoordinatorStatus>, but the corresponding OpenAPIdocument does not mark the return type as nullable.