Open
Conversation
This PR allows for a network interface to be directly used in an `ExtLink` rather than creating a new VNIC atop that device. This is necessary to make use of pseudo-devices like OPTE ports, which are directly used by Viona. The preflight routine has a small change to verify that each interface is only used to host (several) VNICs, or a single exclusive `ExtLink`. This current implementation leaves some cosmetic gaps in VNIC numbering (e.g., `[duo_piano_vn_vnic0, opte1, duo_piano_vn_vnic2]`) -- these don't affect the correctness of setup/teardown.
Collaborator
|
Hey @FelixMcFelix sorry for the delay in looking at this. Happy to work toward getting this in after #135 lands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for a network interface to be directly used in an
ExtLinkrather than creating a new VNIC atop that device. This is necessary to make use of pseudo-devices like OPTE ports, which are directly used by Viona.The preflight routine has a small change to verify that each interface is only used to host (several) VNICs, or a single exclusive
ExtLink. This current implementation leaves some cosmetic gaps in VNIC numbering (e.g.,[duo_piano_vn_vnic0, opte1, duo_piano_vn_vnic2]) -- these don't affect the correctness of setup/teardown.