Skip to content

[1/n] [meta] fix up some schema warnings from tombi - #10815

Closed
sunshowers wants to merge 2 commits into
mainfrom
sunshowers/spr/meta-fix-up-some-schema-warnings-from-tombi
Closed

[1/n] [meta] fix up some schema warnings from tombi#10815
sunshowers wants to merge 2 commits into
mainfrom
sunshowers/spr/meta-fix-up-some-schema-warnings-from-tombi

Conversation

@sunshowers

@sunshowers sunshowers commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

I recently set up Tombi in my IDE, and it produced a few warnings. Clean up the easy ones: nextest tables out of order, and the deprecated authors field in Cargo.toml.

There are a few harder ones left which I haven't touched:

  • out-of-order tables in nexus/examples/
  • out-of-order dotted keys in package-manifest.toml
  • rustfmt.toml being rejected (which actually seems like an outdated schema)

(I haven't set up CI to do Tombi validation so this will probably regress in the future. Happy to do that if there's interest!)

Created using spr 1.3.6-beta.1
Comment thread api_identity/Cargo.toml
name = "api_identity"
description = "macro used for Oxide control plane resources with an identity"
version = "0.1.0"
authors = ["David Pacheco <dap@oxidecomputer.com>"]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field is now deprecated.

@sunshowers
sunshowers requested a review from iliana July 14, 2026 00:25
@sunshowers

Copy link
Copy Markdown
Contributor Author

@iliana would love your thoughts here on whether toml validation is worth setting up in CI

@iliana

iliana commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Can we make it enforce sorting the dependencies sections? If so absolutely yes.

cargo add only attempts to sort new dependencies if packages are already sorted and most aren't. I try to fix things as I work on them but it's really easy for them to fall out of line.

Created using spr 1.3.6-beta.1
@sunshowers sunshowers changed the title [meta] fix up some schema warnings from tombi [1/n] [meta] fix up some schema warnings from tombi Jul 20, 2026
@sunshowers

Copy link
Copy Markdown
Contributor Author

Closing in favor of #11102.

@sunshowers sunshowers closed this Aug 18, 2026
@sunshowers
sunshowers deleted the sunshowers/spr/meta-fix-up-some-schema-warnings-from-tombi branch August 18, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants