Support multiple external addresses in database inventory tables - #11114
Open
bnaecker wants to merge 1 commit into
Open
Support multiple external addresses in database inventory tables#11114bnaecker wants to merge 1 commit into
bnaecker wants to merge 1 commit into
Conversation
bnaecker
force-pushed
the
ben/multiple-eips-in-database-inventory
branch
from
August 19, 2026 23:51
1cf85ce to
c22a827
Compare
- Add a new table `inv_omicron_sled_config_zone_external_ip` to store the external IP information for inventoried zones in `inv_omicron_sled_config_zone`. This lets us support multiple IPs in the table, each with a reference back to the inventory collection and zone it came from. - Migrate schema and old data. This moves the "second service IP" information to the new table, only for the zones where that IP is an external address (Nexus, External DNS, and Boundary NTP). This also drops the now-unused SNAT related columns, but leaves the `second_service_ip` column for things like internal DNS's additional underlay address. - Add model types and update a bunch of callsites and tests.
bnaecker
force-pushed
the
ben/multiple-eips-in-database-inventory
branch
from
August 20, 2026 02:55
c22a827 to
1ed5074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inv_omicron_sled_config_zone_external_ipto store the external IP information for inventoried zones ininv_omicron_sled_config_zone. This lets us support multiple IPs in the table, each with a reference back to the inventory collection and zone it came from.second_service_ipcolumn for things like internal DNS's additional underlay address.