[testing, multicast] Extend commtest with multicast end-to-end coverage - #11118
Open
zeeshanlakhani wants to merge 5 commits into
Open
[testing, multicast] Extend commtest with multicast end-to-end coverage#11118zeeshanlakhani wants to merge 5 commits into
commtest with multicast end-to-end coverage#11118zeeshanlakhani wants to merge 5 commits into
Conversation
zeeshanlakhani
changed the title
commtest with multicast end-to-end coverage.commtest with multicast end-to-end coverage
zeeshanlakhani
force-pushed
the
zl/mcast-e2e-commtest
branch
from
August 20, 2026 08:00
f4ed39b to
8fe769a
Compare
socket2's set_multicast_ttl_v4 passes the TTL as a four-byte c_int, which illumos rejects with EINVAL because IP_MULTICAST_TTL must be a single byte (uchar_t). The multicast pinger now sets the option directly via libc on illumos and keeps the socket2 path on other platforms.
…bing commtest gains a multicast phase driven by --mcast-group: it sends from the host external address, asserts per-group delivery and replication, and writes multicast-connectivity-report.json. The icmp helpers grow the mcast echo scaffolding it uses. The a4x2-deploy job adds per-group host egress routes and mirrors external groups to both switch-facing sidecars, since the elected switch is not knowable at setup time.
…r constants, a4x2-deploy comment polish
zeeshanlakhani
force-pushed
the
zl/mcast-e2e-commtest
branch
from
August 20, 2026 14:23
8fe769a to
a4709d2
Compare
zeeshanlakhani
changed the title
commtest with multicast end-to-end coveragecommtest with multicast end-to-end coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new multicast phase supports repeatable
--mcast-grouparguments with optional source filters, plus--mcast-deny-grouparguments for negative source-filter tests. It creates or reuses the required multicast IP pools, enrolls probes during creation, sends ICMP multicast traffic from the host's external address, and verifies delivery and replication to every member.The "commtest" writes
multicast-connectivity-report.jsonwith per-group and per-member delivery statistics.Includes: