[2/n] remove Generation from omicron-common - #11134
Merged
sunshowers merged 2 commits intoAug 25, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1
sunshowers
changed the title
Created using spr 1.3.6-beta.1
smklein
approved these changes
Aug 24, 2026
sunshowers
deleted the
sunshowers/spr/remove-generation-from-omicron-common
branch
August 25, 2026 16:16
sunshowers
added a commit
that referenced
this pull request
Aug 25, 2026
sunshowers
added a commit
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up from #11129, use omicron-generation-kinds as the place to get
Generationfrom.Use omicron-generation-kinds rather than oxide-generation directly to ensure the correct features all get enabled whenever the dep is used. This allows oxide-generation to be dropped from the workspace hack (since all dependencies resolve to the same set of features).