better message for stray tokens after a ParseWrapper value - #225
Conversation
When a `ParseWrapper<P>` value is followed by tokens that `P` did not consume (for example `bool_expr = true false`), `syn::parse2` rejected them with a bare "unexpected token" (though the span was fine). Produce a better error message in this case, similar to the message you would get from a non-`ParseWrapper` type. Doing this in `ParseWrapper` rather than in individual `Parse` impls keeps those impls composable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
ParseWrapper<P>value is followed by tokens thatPdid not consume (for examplebool_expr = true false),syn::parse2rejected them with a bare "unexpected token" (though the span was fine). Produce a better error message in this case, similar to the message you would get from a non-ParseWrappertype.Doing this in
ParseWrapperrather than in individualParseimpls keeps those impls composable.