handle macro_rules substitutions across the codebase - #230
Open
Conversation
As mentioned in the previous commit, rustc wraps tokens with `None` delimiters in case of declarative macro substitutions. Previously, only `deserialize_any` descended into them. Extend that to also cover all other types. With this change, every `deserialize_*` method that reads a token now starts with a block which looks for this transparent thing. The only exception is `deserialize_bytes` which we use for other purposes. Also, skip over empty macro substitutions within `TokenDe` so that other parts of the code don't need to special-case them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in the previous commit, rustc wraps tokens with
Nonedelimiters in case of declarative macro substitutions. Previously, onlydeserialize_anydescended into them. Extend that to also cover all other types.With this change, every
deserialize_*method that reads a token now starts with a block which looks for this transparent thing. The only exception isdeserialize_byteswhich we use for other purposes.Also, skip over empty macro substitutions within
TokenDeso that other parts of the code don't need to special-case them.