Multirack rss config - #42
Draft
andrewjstone wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR utilizes a new commission API from oxidecomputer/omicron#11143 that allows joining a second rack to another such that each can route DDM traffic to each other over front ports.
The
interconnect_portcode that utilized shell commands to configure interfaces and addresses on illumos was removed in favor of using the new commission API. This API results in sending aMultirackJoinRequestto the multirack join service. The join service then puts theRackNetworkConfigfrom theMultirackJoinRequestinto the bootstore, which gets reconciled in the scrimlet reconcilers such that dpd creates the necessary ports and interfaces, and DDM FSMs are started for those newly created ports.The interconnect ports
qsfp2andqsfp3still have their configuration (PortConfig) automatically generated by voxel. It's just that thatPortConfigis included inRackNetworkConfigand plumbed down via aMultirackJoinRequestnow.With this PR, and oxidecomputer/omicron#11143, and a proper 2 rack configuration voxel will end up running RSS on the first rack, and then automatically joining the second rack via the commission API.
The demo asciicast can be played in asciinema to show what occurs when both this PR and the omicron one are used in conjunction.
I've asked @nickelization to try to get this integrated, and would appreciate any help and guidance from @sion42x.