Skip to content

perf(skip masks): skip masks as roaring bitmaps in fetch#421

Merged
forshev merged 3 commits into
mainfrom
420-skip-mask-as-roaring-bitmap
Jun 3, 2026
Merged

perf(skip masks): skip masks as roaring bitmaps in fetch#421
forshev merged 3 commits into
mainfrom
420-skip-mask-as-roaring-bitmap

Conversation

@forshev
Copy link
Copy Markdown
Collaborator

@forshev forshev commented May 6, 2026

Description

Read skip masks as roaring bitmap for fetch

Fixes #420


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

Codecov Report

❌ Patch coverage is 70.83333% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.66%. Comparing base (5647ba2) to head (a750a36).

Files with missing lines Patch % Lines
skipmaskmanager/loader.go 52.94% 11 Missing and 5 partials ⚠️
skipmaskmanager/encoding.go 58.33% 10 Missing ⚠️
skipmaskmanager/skip_mask_manager.go 84.37% 3 Missing and 2 partials ⚠️
frac/active_index.go 85.71% 1 Missing ⚠️
skipmaskmanager/iterator_asc.go 83.33% 1 Missing ⚠️
skipmaskmanager/iterator_desc.go 83.33% 1 Missing ⚠️
skipmaskmanager/merged_iterator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   70.65%   70.66%           
=======================================
  Files         219      219           
  Lines       17023    17059   +36     
=======================================
+ Hits        12028    12055   +27     
- Misses       4096     4102    +6     
- Partials      899      902    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin requested review from cheb0 and eguguchkin May 12, 2026 10:36
@forshev forshev force-pushed the 420-skip-mask-as-roaring-bitmap branch from 7d69985 to ab18105 Compare May 12, 2026 11:17
@eguguchkin eguguchkin added this to the v0.72.0 milestone May 18, 2026
Comment thread skipmaskmanager/skip_mask_manager.go Outdated
Comment thread skipmaskmanager/skip_mask_manager.go Outdated
Comment thread skipmaskmanager/loader.go Outdated
@forshev forshev force-pushed the 420-skip-mask-as-roaring-bitmap branch from ab18105 to ce85e07 Compare May 29, 2026 11:25
@forshev forshev force-pushed the 420-skip-mask-as-roaring-bitmap branch from ce85e07 to 5d7f989 Compare June 3, 2026 12:41
@forshev forshev force-pushed the 420-skip-mask-as-roaring-bitmap branch from 5d7f989 to a750a36 Compare June 3, 2026 12:51
@forshev forshev merged commit dadf267 into main Jun 3, 2026
8 checks passed
@forshev forshev deleted the 420-skip-mask-as-roaring-bitmap branch June 3, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use roaring bitmaps to eval skip masks in fetch

4 participants