Add BeamLine.from/to_file Functions#57
Merged
ax3l merged 1 commit intopals-project:mainfrom Jan 26, 2026
Merged
Conversation
Hide more internals of serialization (more user friendly) and prepare for increased complexity of the root structure of PALS.
2 tasks
EZoni
reviewed
Jan 20, 2026
Comment on lines
215
to
+217
| # Read back from file | ||
| with open(yaml_file, "r") as file: | ||
| loaded_yaml_data = yaml.safe_load(file) | ||
| print(f"\nComprehensive lattice YAML:\n{file.read()}") |
Member
There was a problem hiding this comment.
It looks to me like this with block can be removed now, correct? I don't see any other instructions besides the print statement within the block.
Member
Author
There was a problem hiding this comment.
Oh I left them intentionally to just plot the content we wrote in the test.
EZoni
reviewed
Jan 20, 2026
Comment on lines
270
to
+272
| # Read back from file | ||
| with open(json_file, "r") as file: | ||
| loaded_json_data = json.loads(file.read()) | ||
| print(f"\nComprehensive lattice JSON:\n{file.read()}") |
Member
There was a problem hiding this comment.
It looks to me like this with block can be removed now, correct? I don't see any other instructions besides the print statement within the block.
Member
Author
There was a problem hiding this comment.
Oh I left them intentionally to just plot the content we wrote in the test.
EZoni
approved these changes
Jan 20, 2026
Member
|
This looks good to me. I think it can be merged after the two comments above are addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hide more internals of serialization (more user friendly) and prepare for increased complexity of the root structure of PALS.
Close #56