Guard the dashboard against unhandled errors - #31
Merged
Merged
Conversation
The dashboard parsed req.url without guarding the call. A leading // makes the target protocol-relative, so the next segment is read as the host, and a host cannot contain a slash. Bots that scan for secrets requested //%2F.env, where %2F is an encoded slash, the parse threw, and the process crashed. While at it, guard the other paths of the same shape. Signed-off-by: Cosmin Paraschiv <cosmin@parity.io>
mordamax
approved these changes
Sep 17, 2026
csmnprschv
deleted the
cosmin-guard-dashboard-against-unhandled-errors
branch
September 17, 2026 09:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dashboard parsed req.url without guarding the call. A leading //
makes the target protocol-relative, so the next segment is read as the
host, and a host cannot contain a slash. Bots that scan for secrets
requested //%2F.env, where %2F is an encoded slash, the parse threw,
and the process crashed.
While at it, guard the other paths of the same shape.