Repository navigation
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
elle-j
approved these changes
Nov 10, 2026
Comment on lines
+1442
to
+1449
| string_literal | ||
| .unescape_bytes() | ||
| .map_err(|error| { | ||
| TranslationError::InvalidLiteral(format!("`{string}`: {error}")) | ||
| })? | ||
| .iter() | ||
| .map(|byte| format!("{byte:02x}")) | ||
| .collect() |
Contributor
There was a problem hiding this comment.
Similar to my earlier comment in related PR 723, replacing the preexisting decoding logic with calling the unescape_bytes() could also be done for the yul side so that it's shared by all sites.
Member
Author
There was a problem hiding this comment.
Right, I've decided to close and instead brush this PR up to address a bunch of related problems. Could you please review again?
Closed
Signed-off-by: xermicus <cyrill@parity.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #697
Closes #698
Closes #699
Closes #708
Plus some drive-by fixes