Photos prototype#152
Conversation
|
I've only taken a quick look so far, just wonder this'll be a standalone application for demo, or should it be wired with our shared component in |
For now, it is dApp/demo which is bundled as a part of web3-storage UI, exactly to the landing page: https://github.com/paritytech/web3-storage/pull/234/changes#diff-0b82a96cf448d5175437b0503b298050e794bc2397be92686ae0b0f10f548395R222 @franciscoaguirre Later, we can/should also think about deploying this to the Dotli/DotNS :)
It should not leak Photos-specific api/stuff to the @franciscoaguirre Ilia's SDK unification and first refactor is coming here: #160 - when this PR lands, you could check and reuse (if not already) - sorry for that, I mean possible conflicts 🙃 |
|
@bkontur That PR looks good. I'll rebase and see if I can reuse more things |
cc88d3c to
89285b1
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
bkontur
left a comment
There was a problem hiding this comment.
@franciscoaguirre maybe just small clean up here: https://github.com/paritytech/web3-storage/pull/152/changes#r3480429700
Addresses #133
An example photos dapp to showcase a normal app using the precompiles
The app is divided into parts to facilitate the review: