Skip to content

Photos prototype#152

Merged
franciscoaguirre merged 10 commits into
devfrom
dapp-example
Jun 26, 2026
Merged

Photos prototype#152
franciscoaguirre merged 10 commits into
devfrom
dapp-example

Conversation

@franciscoaguirre

@franciscoaguirre franciscoaguirre commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Addresses #133

An example photos dapp to showcase a normal app using the precompiles

The app is divided into parts to facilitate the review:

  1. This one: DESIGN.md, scaffold, contract and uploading files
  2. Photos: part 2 #229: albums, computed root anchor, dowloading files, editing
  3. Photos: part 3 #234: UI scaffold
  4. Photos: part 4 #235: UI grid, upload, download, albums, thumbnails
  5. Photos: part 5 #236: Editing images, renaming

Comment thread docs/design/photos.md Outdated
Comment thread docs/design/photos.md Outdated
Comment thread docs/design/photos.md Outdated
@franciscoaguirre franciscoaguirre marked this pull request as ready for review June 23, 2026 16:37
Comment thread user-interfaces/photos/contracts/IDriveRegistry.sol
@danielbui12

danielbui12 commented Jun 25, 2026

Copy link
Copy Markdown
Member

I've only taken a quick look so far, just wonder this'll be a standalone application for demo, or should it be wired with our shared component in user-interfaces/shared & user-interfaces/sdk?

@bkontur

bkontur commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

I've only taken a quick look so far, just wonder this'll be a standalone application for demo

For now, it is dApp/demo which is bundled as a part of web3-storage UI, exactly to the landing page: https://github.com/paritytech/web3-storage/pull/234/changes#diff-0b82a96cf448d5175437b0503b298050e794bc2397be92686ae0b0f10f548395R222

@franciscoaguirre Later, we can/should also think about deploying this to the Dotli/DotNS :)

should it be wired with our shared component in user-interfaces/shared & user-interfaces/sdk?

It should not leak Photos-specific api/stuff to the user-interfaces/shared & user-interfaces/sdk, but the opposite it should use sdk as much as possible, which I briefly checked is correct here.

@franciscoaguirre Ilia's SDK unification and first refactor is coming here: #160 - when this PR lands, you could check and reuse (if not already) - sorry for that, I mean possible conflicts 🙃

@franciscoaguirre

Copy link
Copy Markdown
Collaborator Author

@bkontur That PR looks good. I'll rebase and see if I can reuse more things

@socket-security

socket-security Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​types/​node@​22.20.01001008196100
Addednpm/​polkadot-api@​2.1.7881009497100
Addednpm/​viem@​2.53.19710010097100

View full report

Comment thread user-interfaces/photos/scripts/build.sh

@bkontur bkontur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscoaguirre franciscoaguirre added this pull request to the merge queue Jun 26, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 26, 2026
@franciscoaguirre franciscoaguirre added this pull request to the merge queue Jun 26, 2026
Merged via the queue into dev with commit cb4d159 Jun 26, 2026
41 checks passed
@franciscoaguirre franciscoaguirre deleted the dapp-example branch June 26, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants