Skip to content

fix: Resolve flaky test ParseLiveQuery handle invalid websocket payload length #10241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdullahZulfiqar2005 wants to merge 2 commits into
base: alpha
Choose a base branch
from
+11 −8
Open

fix: Resolve flaky test ParseLiveQuery handle invalid websocket payload length #10241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
483c38e
fix: resolve flaky livequery websocket test by removing done callback
AbdullahZulfiqar2005 Mar 18, 2026
8eb3478
Merge branch 'alpha' into fix-flaky-test-9272-v2
mtrezza Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions spec/ParseLiveQuery.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ describe('ParseLiveQuery', function () {
await expectAsync(query.subscribe()).toBeRejectedWith(new Error('Invalid session token'));
});

it_id('4ccc9508-ae6a-46ec-932a-9f5e49ab3b9e')(it)('handle invalid websocket payload length', async done => {
it_id('4ccc9508-ae6a-46ec-932a-9f5e49ab3b9e')(it)('handle invalid websocket payload length', async () => {
await reconfigureServer({
liveQuery: {
classNames: ['TestObject'],
Expand All @@ -982,15 +982,18 @@ describe('ParseLiveQuery', function () {
const client = await Parse.CoreManager.getLiveQueryController().getDefaultLiveQueryClient();
client.socket._socket.write(Buffer.from([0x89, 0xfe]));

subscription.on('update', async object => {
expect(object.get('foo')).toBe('bar');
done();
const updatePromise = new Promise(resolve => {
subscription.on('update', updatedObject => {
expect(updatedObject.get('foo')).toBe('bar');
resolve();
});
});
// Wait for Websocket timeout to reconnect
setTimeout(async () => {
object.set({ foo: 'bar' });
await object.save();
}, 1000);
await sleep(1000);
object.set({ foo: 'bar' });
await object.save();

await updatePromise;
});

it_id('39a9191f-26dd-4e05-a379-297a67928de8')(it)('should execute live query update on email validation', async done => {
Expand Down