Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions spec/ParseServerRESTController.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -675,4 +675,22 @@ describe('ParseServerRESTController', () => {
const result = await Parse.Push.getPushStatus(pushStatusId);
expect(result.id).toBe(pushStatusId);
});

it('should not convert undefined values to null on update with directAccess', async () => {
const createRes = await RESTController.request('POST', '/classes/MyObject', {
presentField: 'hello',
});
expect(createRes.objectId).toBeDefined();

await RESTController.request('PUT', `/classes/MyObject/${createRes.objectId}`, {
presentField: 'updated',
absentField: undefined,
});

const getRes = await RESTController.request('GET', `/classes/MyObject/${createRes.objectId}`);

expect(getRes.presentField).toBe('updated');
expect(getRes.absentField).toBeUndefined();
expect('absentField' in getRes).toBe(false);
});
});
18 changes: 17 additions & 1 deletion src/ParseServerRESTController.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ function getAuth(options = {}, config) {
});
}

function stripUndefined(obj) {
if (obj === null || obj === undefined || typeof obj !== 'object') {
return obj;
}
if (Array.isArray(obj)) {
return obj.map(item => item === undefined ? null : stripUndefined(item));
}
const result = {};
for (const key of Object.keys(obj)) {
if (obj[key] !== undefined) {
result[key] = stripUndefined(obj[key]);
}
}
return result;
}

function ParseServerRESTController(applicationId, router) {
function handleRequest(method, path, data = {}, options = {}, config) {
// Store the arguments, for later use if internal fails
Expand Down Expand Up @@ -113,7 +129,7 @@ function ParseServerRESTController(applicationId, router) {
return new Promise((resolve, reject) => {
getAuth(options, config).then(auth => {
const request = {
body: data,
body: stripUndefined(data),
config,
auth,
info: {
Expand Down
Loading